[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdevelop/parts/cvs/globalcvs
From:       Oswald Buddenhagen <ossi () kde ! org>
Date:       2003-03-05 16:33:07
[Download RAW message or body]

On Wed, Mar 05, 2003 at 04:08:25PM +0100, Harald Fernengel wrote:
> CVS commit by harald: 
> 
> +        init = "cvs -d " + 
> +               KShellProcess::quote(form->root_edit->text()) + " init && ";
> +    QString command = init + "cd " + KShellProcess::quote(dir) +
> +                      " && cvs -d " + KShellProcess::quote(form->root_edit->text()) + 
> +                      " import -m '" + KShellProcess::quote(form->message_edit->text()) + "' " +
> +                      KShellProcess::quote(form->repository_edit->text()) + " " + 
> +                      KShellProcess::quote(form->vendor_edit->text()) + " " + 
> +                      KShellProcess::quote(form->release_edit->text());
> 
too bad that KShellProcess is deprecated. and
" import -m '" + KShellProcess::quote(form->message_edit->text()) + "' "
can hardly be called "proper" quoting.
also, you'd save some code & cycles by using the += operator (or the
append() member, fwiw) instead of +.

greetings

-- 
Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
--
Chaos, panic, and disorder - my work here is done.
[prev in list] [next in list] [prev in thread] [next in thread]