[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: qt-copy/src/widgets - BIC ??
From:       Christoph Cullmann <cullmann () babylon2k ! de>
Date:       2003-03-02 20:59:38
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

get nice linking errors in konqui now, some bic changes ?

r-subscripts -DNDEBUG -DNO_DEBUG -O2 -Wformat-security 
- -Wmissing-format-attribute -fno-exceptions -fno-check-new -fno-common 
- -DQT_CLEAN_NAMESPACE -DQT_NO_COMPAT -DQT_NO_ASCII_CAST -D_GNU_SOURCE    -o 
konqueror -R /opt/kde/lib -R /usr/X11R6/lib -L/usr/X11R6/lib -L/opt/kde/lib  
dummy.o konqueror.la
./.libs/konqueror.so: undefined reference to `QCheckBox::hitButton(QPoint 
const&) const'
collect2: ld returned 1 exit status


On Monday 17 February 2003 17:23, Carsten Pfeiffer wrote:
> CVS commit by pfeiffer:
>
> apply Anders' patch (will be in 3.2): don't toggle checkboxes/radiobuttons
> when hitting empty label area
>
>
>   M +12 -0     qcheckbox.cpp   1.48
>   M +1 -1      qcheckbox.h   1.47
>   M +9 -1      qradiobutton.cpp   1.48
>
>
> --- qt-copy/src/widgets/qcheckbox.cpp  #1.47:1.48
> @@ -343,3 +343,15 @@ void QCheckBox::updateMask()
>      setMask(bm);
>  }
> +
> +bool QCheckBox::hitButton( const QPoint &pos ) const
> +{
> +    QRect r = QStyle::visualRect( style().subRect(
> QStyle::SR_CheckBoxFocusRect, this ), this ); +    if (
> qApp->reverseLayout() ) {
> +        r.setRight( width() );
> +    } else {
> +        r.setLeft( 0 );
> +    }
> +    return r.contains( pos );
> +}
> +
>  #endif
>
> --- qt-copy/src/widgets/qcheckbox.h  #1.46:1.47
> @@ -73,5 +73,5 @@ protected:
>      void    drawButtonLabel( QPainter * );
>      void    updateMask();
> -
> +    virtual bool hitButton( const QPoint &pos ) const;
>  private:        // Disabled copy constructor and operator=
>  #if defined(Q_DISABLE_COPY)
>
> --- qt-copy/src/widgets/qradiobutton.cpp  #1.47:1.48
> @@ -175,5 +175,13 @@ QSize QRadioButton::sizeHint() const
>  bool QRadioButton::hitButton( const QPoint &pos ) const
>  {
> -    return rect().contains( pos );
> +    QRect r =
> +        QStyle::visualRect( style().subRect(
> QStyle::SR_RadioButtonFocusRect, +                                         
>    this ), this );
> +    if ( qApp->reverseLayout() ) {
> +        r.setRight( width() );
> +    } else {
> +        r.setLeft( 0 );
> +    }
> +    return r.contains( pos );
>  }

- -- 
Christoph Cullmann
KDE Developer, kde.org Co-Maintainer
http://www.babylon2k.de, cullmann@kde.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+YnC9yPjDGePm9UIRAmBPAJ9dpwBb0Pl6UBo6BdJgeQiO0zQ4sgCfeZZY
LB65p6z68Ug4cZawPHpZKZw=
=YGq9
-----END PGP SIGNATURE-----

[prev in list] [next in list] [prev in thread] [next in thread]