[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE_3_1_BRANCH: kdebase/klipper
From:       Ralf Nolden <nolden () kde ! org>
Date:       2003-01-21 12:24:53
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Dienstag, 21. Januar 2003 13:19, Carsten Pfeiffer wrote:
> On Tuesday 21 January 2003 12:21, Dirk Mueller wrote:
> > On Die, 21 Jan 2003, Ralf Nolden wrote:
> > > Dirk, this does seem to be wrong. It needs to be named
> > > cr22-app-klipper.png which is the size that's missing. Then it gets
> > > installed correctly, just needs to be renamed. I'll fix this now in
> > > branch and head.
> >
> > As long as you don't fix the code itself I think you broke it now:
>
> Right, it's indended to be 22 and action, not app.
>
> > try at fixing #52823. God knows why in applet mode, it still prefers to
> > load the crystal version.
>
> FWIW, it works fine in applet mode as well.

Guys,

I'm just talking with tackat on the phone and he says that I should leave it 
as 22-app-klipper. The panel applet itself is not affected because the icon 
loader looks the icon up in apps as well, so there is no need to move it to 
actions (also keeping it in apps is the consistent way to do that).

Instead, there is another bug or behavior that needs to be fixed, which the 
current code doesn't handle:

If klipper runs as a systray icon it needs to load the 22x22 size, but if it 
runs as a separate panel applet, it needs to dynamically load the right size 
that the panel icons use, so it adapts its icon to the panel icon size. This 
still needs to be fixing in the code, the icons can stay now as they are, all 
in apps.

Ralf
>
> Cheers
> Carsten Pfeiffer

- -- 
We're not a company, we just produce better code at less costs.
- --------------------------------------------------------------------
Ralf Nolden
nolden@kde.org

The K Desktop Environment       The KDevelop Project
http://www.kde.org              http://www.kdevelop.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+LTwVu0nKi+w1Ky8RAqQyAKCN/NSywTCDRRhFeBYVd91beNT9LQCfUDmK
ivtqW5y1v19e2OlyBXOZlGk=
=zrrW
-----END PGP SIGNATURE-----


[prev in list] [next in list] [prev in thread] [next in thread]