[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: koffice/filters/kword/oowriter
From:       Montel laurent <montell () club-internet ! fr>
Date:       2003-01-20 13:06:14
[Download RAW message or body]

Le Sunday 19 January 2003 16:52, Nicolas Goutte a écrit :
> I am sorry, perhaps it is nitpicking but I do not understand:
> - Why are you removing the XML declaration ( <?xml )? KWord documents are
> supposed to have it always.

> - Why the change from "root" to "maindoc.xml"? If there is a real problem,
> it is serious, as most KWord import filters use "root".

KoDocument::createDomDocument allow to create xml declaration.
I changed for making as in ooimpress filter.

> - Why no error message when "maindoc.xml" is not writable? It is not a
> document info that you can skip. This is the main document. If it cannot be
> written, the filter has failed.

Oops it's right I removed so much line.
I reverse it.

Regards.

>
> Have a nice day/evening/night!
>
> --- Original Message ---
>
> >List:     kde-cvs
> >Subject:  koffice/filters/kword/oowriter
> >
> >>From:     Laurent Montel <montell () club-internet ! fr>
> >
> >Date:     2003-01-19 13:45:37
> >
> >CVS commit by mlaurent:
> >
> >Minor improvment
> >
> >
> >  M +30 -17    oowriterimport.cc   1.7
> >  M +1 -0      oowriterimport.h   1.3
>
> (...)

[prev in list] [next in list] [prev in thread] [next in thread]