[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdeutils/klaptopdaemon [POSSIBLY UNSAFE]
From:       George Staikos <staikos () kde ! org>
Date:       2003-01-15 22:02:39
[Download RAW message or body]

On January 15, 2003 16:09, Paul Campbell wrote:
> On Wednesday 15 January 2003 12:58 pm, Dirk Mueller wrote:
> > On Mit, 15 Jan 2003, Paul Campbell wrote:
> > >   A            makecrc.cpp   1.1 [POSSIBLY UNSAFE: printf]
> > >   M +70 -16    acpi.cpp   1.3 [POSSIBLY UNSAFE: system]
> > >   M +49 -23    acpi_helper.cpp   1.2 [POSSIBLY UNSAFE:
> > > printf] M +181 -43   portable.cpp   1.43 [POSSIBLY UNSAFE:
> > > system,printf]
> >
> > Any reason why you use system all over the place instead of
> > using KProcess ?
>
> force of habit ... I'll go fix it
>
> BTW makecrc and acpihelper are not traditional KDE apps - I
> believe printf is appropriate in them

  They still need to be very careful about their use of printf though.

-- 

George Staikos

[prev in list] [next in list] [prev in thread] [next in thread]