[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kdeui
From:       Antonio Larrosa =?iso-8859-1?q?Jim=E9nez?= <larrosa () kde ! org>
Date:       2003-01-10 10:50:44
[Download RAW message or body]

El Viernes, 10 de Enero de 2003 09:35, Hans Petter Bieker escribió:
> On Thu, 9 Jan 2003, Antonio Larrosa Jimenez wrote:
>
> You should perhaps add some documentation for kdatepicker.. And why do

Oops, yes, thanks, I forgot about that one.

> you use QDate::toString() to get a date string? Please use
> KLocale::locale()->formatDate instead.

Ah, you're right. That'll work much better. 

>
> BTW: Why don't you use QDates for the keys instead of strings? And if

I thought that using QStrings as keys would be faster than using QDates as 
it's what's usually used, so it may be more optimized than generating 
QDates hashes.

> you're going to use strings, why not use ISO Dates instead?
>

Well, they're used as index, not to be shown to the user, so the only 
options that I had in mind where to use what I used or use 
QDate::toString, but I thought that toString would do too many other 
things that are not needed. So I went for the easy and fast solution. 
Anyway, if you think that it should use ISO Dates as index (or QDate 
objects), feel free to change it, I don't have a strong opinion here :)

Greetings,

--
Antonio Larrosa Jimenez
KDE developer - larrosa@kde.org
http://developer.kde.org/~larrosa/
Mejor leer algo en inglés que una adivinanza en español.
[prev in list] [next in list] [prev in thread] [next in thread]