[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kdecore [POSSIBLY UNSAFE]
From:       Montel laurent <montell () club-internet ! fr>
Date:       2003-01-04 18:25:33
[Download RAW message or body]

Le Saturday 04 January 2003 19:19, Hans Petter Bieker a écrit :
> On Sat, 4 Jan 2003, Montel laurent wrote:
> > koffice can't compile with new "klocale.h"
>
> It should still work if you undefine KDE_NO_COMPAT
>
Ok I will remove KDE_NO_COMPAT in koffice.

> > is it not possible to keep compatibility with old api ?
>
> Well, it is possible, and I have kept it compatible. But still, the old
> API doesn't make much sense anymore after the introduction of
> KCalendarSystem. It is therefore @deprecated and in the KDE compat
> section.

I saw.

>
> KLocale::monthName(int, bool) const returns the translated name of the
> month. Changing that to return the name of the month in the prefered
> calendar would not be compatible, so it's therefore kept unchanged.

ok

> That is, it returns the name of the Gregorian month.
>
> > Why did you make "private" "monthName(int i, bool shortName = false)
> > const;" and "QString weekDayName(int i, bool shortName = false) const;" ?
> > What is the problem with these function ?
>
> They only work with the Gregorian calendar. Programs using
> KLocale::monthName() should be ported to use KCalendarSystem instead.

Ok so it's not possible for koffice because I think that koffice 1.3 will 
support kde3.1 and not kde 3.2.
So for the moment I remove kde_no_compat.

Regards.

> And KDE_NO_COMPAT is a tool for finding code that should be
> updated.
>
> Norwegian University of Science and Technology, Engineering Cybernetics
>           bieker@itk.ntnu.no / bieker@kde.org / +47 97651633
>                 Dagaliveien 25 A  |  Elgesetergate 23 B
>                 N-0776 Oslo       |  N-7030 Trondheim

[prev in list] [next in list] [prev in thread] [next in thread]