[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdenonbeta/konqsidebar_plugins/konqsidebarnews/rdfservice
From:       Marcus Camen <mcamen () mcamen ! de>
Date:       2002-12-11 21:31:22
[Download RAW message or body]

CVS commit by mcamen: 

Do not unnecessarily loop over all RDF sources


  M +4 -4      manager.cpp   1.2


--- kdenonbeta/konqsidebar_plugins/konqsidebarnews/rdfservice/manager.cpp  #1.1:1.2
@@ -76,10 +76,10 @@ void Manager::detach_rdfsource(uint id)
       }
 
-    // TODO: for -> while
-    RDFSource *search_rdfsource;
     for (RDFSource *current = m_rdfsources.first(); current; current = m_rdfsources.next())
       if (current->getId() == id)
-        search_rdfsource = current;
-    m_rdfsources.remove(search_rdfsource);
+        {
+          m_rdfsources.remove();
+          current = m_rdfsources.last();
+        }
   }
 


[prev in list] [next in list] [prev in thread] [next in thread]