[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdenetwork/ktalkd/ktalkd [POSSIBLY UNSAFE]
From:       David Faure <david () mandrakesoft ! com>
Date:       2002-12-11 20:38:26
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wednesday 11 December 2002 19:40, Lubos Lunak wrote:
> CVS commit by lunakl: 
> 
> I hope I haven't broken anything here, but the code was really a mess.
> 
> 
>   M +10 -22    find_user.cpp   1.20
>   M +6 -5      machines/answmach.cpp   1.15 [POSSIBLY UNSAFE: printf]
>   M +19 -1     prot_talkd.h   1.3 [POSSIBLY UNSAFE: syslog]

Thanks a lot for the fixes, but ..... prot_talkd.h comes straight from the current
talkd sources (part of the netkit package), it should remain unchanged.

Plus, changing the size of the CTL_MSG struct is definitely wrong, it'll break
the protocol. TTY_SIZE has to remain 16. It's the max size as of the protocol,
not the max size as of what the system knows.

Can I let you revert the changes to prot_talkd.h and fix find_user.cpp accordingly?
I don't feel confident fixing strcpy/strcat/etc. stuff correctly :}

Thanks a lot,
David.

- -- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
Get the latest KOffice - http://download.kde.org/stable/koffice-1.2/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE996JC72KcVAmwbhARAhcJAJ9HhUIL4urb4i3ur05y0ONLHvspkwCeL/9f
FuSVH4I9l0ZhYU7bzh4Qruk=
=7Q0h
-----END PGP SIGNATURE-----

[prev in list] [next in list] [prev in thread] [next in thread]