[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: quanta [POSSIBLY UNSAFE]
From:       Oswald Buddenhagen <ossi () kde ! org>
Date:       2002-12-08 17:01:49
[Download RAW message or body]

On Sun, Dec 08, 2002 at 06:55:46PM +0200, Andras Mantia wrote:
> On 2002. December 08., Sunday 17:35, Dirk Mueller wrote:
> > On Son, 08 Dez 2002, Andras Mantia wrote:
> > > -  m_process = new KShellProcess;
> > > +  m_process = new KProcess;
> > > +  m_process->setUseShell(true);
> >
> > are you sure that you *want* to have a shell at all?
> 
> As shell script should be able to be accepted as Quanta plugins, yes I think I 
> need the shell...
>
no. set the executable bit on the script and it is treatet as any other
program. you need a shell only if you need to expand shell metacharacter
(variables, pipes/redirections) _at the command line_.

>  BTW, Ossi's idea about an "expandFilename(const QString &name);"
>  method would be helpful. As I saw from the commits log, it would be
>  useful also fo Cervisia...
> 
yup. i think this should go into qt, though (if it is not already). qdir
provides several functions for expanding/normalizing file names already.

greetings

-- 
Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
--
Chaos, panic, and disorder - my work here is done.
[prev in list] [next in list] [prev in thread] [next in thread]