[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdeextragear-1/kchat [INSECURITY]
From:       Waldo Bastian <bastian () kde ! org>
Date:       2002-12-05 18:35:45
[Download RAW message or body]

CVS commit by waba: 

Add proper quoting


  M +4 -2      socketadministration.cpp   1.7 [INSECURITY]


--- kdeextragear-1/kchat/socketadministration.cpp:1.6	Tue Jul 23 12:25:24 2002
@@ -19,9 +19,11 @@
 #include <qwhatsthis.h>
 #include <qimage.h>
 #include <qpixmap.h>
+#include <qfile.h>
 #include <klocale.h>
 #include <qhostaddress.h>
 #include <kapplication.h>
+#include <kprocess.h>
 
 #include <kmessagebox.h>
 
@@ -128,9 +130,9 @@
    {
     QString address = connections->selectedItem()->text(2);
     QString query = "ping -w 10 -c 1 ";
-    query += address;
+    query += KProcess::quote(address);
     FILE *pipe;
-    pipe = popen (query.ascii(), "r");
+    pipe = popen (QFile::encodeName(query), "r");
     char ch;
     QString answer;
     bool firstch = false;

[prev in list] [next in list] [prev in thread] [next in thread]