[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: koffice/lib/kofficecore
From:       David Faure <david () mandrakesoft ! com>
Date:       2002-12-05 12:16:17
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

> --- koffice/lib/kofficecore/koDocument.h:1.131	Wed Dec  4 13:59:17 2002
> @@ -557,6 +557,12 @@
>      
>      bool hasExternURL();
>      
> +    /**
> +     * Sets the document URL to @p url
> +     * KParts doesn't really allow this, but it is needed for undo of setStoreInternal()
> +     */
> +    void setUrl( KURL url ) { m_url = url; }

Ok. Please use const KURL& url to reduce data copying though. 
setURL would also be more consistent than setUrl (just like it's KURL, not KUrl)

Thanks :)

- -- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
Get the latest KOffice - http://download.kde.org/stable/koffice-1.2/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE970OS72KcVAmwbhARAiLSAJ4i6NtJdvP+X4HTc8lwc83a6m5DdACfR82z
R4dtVh968voxOuCpFZB/7lo=
=jBF7
-----END PGP SIGNATURE-----

[prev in list] [next in list] [prev in thread] [next in thread]