[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/kdesktop
From:       David Faure <david () mandrakesoft ! com>
Date:       2002-12-04 20:19:42
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wednesday 04 December 2002 20:18, Christian Loose wrote:
> Am Mittwoch, 4. Dezember 2002 19:54 schrieb Chris Howells:
> > CVS commit by howells:
> >
> > Whoops, forgot to change these ones.
> >
> >
> >   M +2 -2      minicli.cpp   1.138
> 
> Just as a suggestion...Isn't this a good case for a constant?? So the next
> person who changes it, only has to change it in one place?

When someone wants to change the icon, he should change the _icon_
contents, not its name anyway. Now that Chris has set a consistent name,
there won't be a need for such a change, ever. We have "hardcoded" icon
names everywhere, this is no unique case.

- -- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
Get the latest KOffice - http://download.kde.org/stable/koffice-1.2/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE97mNe72KcVAmwbhARAlKHAJ9r7KFdDNq0es/TIQ1abDHcT61usACaAobk
5cdryBmAfv3lxgd+7z9xCHE=
=9r2p
-----END PGP SIGNATURE-----

[prev in list] [next in list] [prev in thread] [next in thread]