[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kdecore
From:       Stephan Kulow <coolo () kde ! org>
Date:       2002-11-30 20:57:29
[Download RAW message or body]

On Freitag, 29. November 2002 22:16, Andreas Beckermann wrote:
> CVS commit by andreas:
>
> HEAD is open again so lets go :)
> this patch adds two nice features (to me at least :)) to kdDebug:
> - support debug-signals. output target=5 in the kdebugrc makes KDebug emit
> a signal (notify()) which can be used in the application. for example the
> app may provide a separate widget displaying errors and warnings.
> - make kdDebug DCOP-aware. KDebugDCOPIface::notifyKDebugConfigChanged()
> deletes the internal debug cache and forces kDebugBackend() to re-parse
> kdebugrc. this is very useful for programs with a big startup time - you
> don't need to quit and re-start it if you want to enable/disable certain
> debug areas. i've been using most of this patch for quite some time in my
> project, so i hope there won't be big problems :)
>
> Could anyone be so kind to review this patch concerning binary
> compatibility?
>
>
>   A            kdebugdcopiface.cpp   1.1
>   A            kdebugdcopiface.h   1.1
>   M +2 -2      Makefile.am   1.304
>   M +85 -24    kdebug.cpp   1.119
>   M +82 -2     kdebug.h   1.62
>   M +2 -0      kdebugrc   1.25

OK, I talked with quite some others and noone liked the debug-signal thing.
The DCOP change is nice and makes debugging easier, but the signals stuff
appears to me too special. The app would have to the signal processing and
the user can't control that, that's not the idea that drives kdebug. 

So I ask you hereby to revert that part or I will have to ;(

Greetings, Stephan

[prev in list] [next in list] [prev in thread] [next in thread]