[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdenetwork/lanbrowsing/lisa
From:       Alexander Neundorf <neundorf () kde ! org>
Date:       2002-11-04 21:43:58
[Download RAW message or body]

CVS commit by neundorf: 

security fix, as posted on security@kde.org (but nobody answered), so
finally I commit

mainly:

+      if (socketName.length() >= sizeof(serverAddr.sun_path))
+      {
+         std::cout<<"NetManager::prepare: your logname  \""<<logname<<"\"
is longer than 60 characters, exiting."<<std::endl;
+         return 0;
+      }
       memset((void*)&serverAddr, 0, sizeof(serverAddr));
       serverAddr.sun_family      = AF_LOCAL;
-      strcpy(serverAddr.sun_path,socketName.data());
+
strncpy(serverAddr.sun_path,socketName.data(),sizeof(serverAddr.sun_path));


and:

       int length=strlen(tmpBuf)+1;
+      if (length<(4*1024))
+         sscanf(tmpBuf,"%u %s\n",&tmpIP,tmpName);

Alex


  M +6 -5      configfile.cpp   1.4
  M +73 -66    netmanager.cpp   1.18

[prev in list] [next in list] [prev in thread] [next in thread]