[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE_3_0_BRANCH: kdemultimedia/kaboodle
From:       Montel laurent <montell () club-internet ! fr>
Date:       2002-09-02 5:25:47
[Download RAW message or body]

Le Sunday 01 September 2002 23:56, Neil Stevens a écrit :
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Sunday September 01, 2002 07:49, Laurent Montel wrote:
> > kdemultimedia/kaboodle kaboodle_factory.cpp,1.10.2.2,1.10.2.3
> > kaboodle_part.cpp,1.24,1.24.2.1 kaboodle_part.h,1.13,1.13.2.1
> > userinterface.cpp,1.14.2.1,1.14.2.2 Author: mlaurent
> >
> >
> > Modified Files:
> >          kaboodle_factory.cpp kaboodle_part.cpp kaboodle_part.h
> >          userinterface.cpp
> > Log Message:
> > Fix kaboodle crash when it was embedded into konqueror
>
> What crash was this?

Before :
KParts::Part *KaboodleFactory::createPartObject(QWidget *widgetParent, const 
char *widgetName, QObject *parent, const char *name, const char *className, 
const QStringList &)
{
    QObject *obj = new KaboodlePart(widgetParent, name, true, true);
}

=> createPartObject doesn't return a object
=> so when we create a embedded object into konqueror
=> konqueror crashs !

An I fixe kaboodlepart to use parentWidget and parent object  as discussed 
with david.


Regards.


>
> If you mean the one that was discussed on the lists before, I already
> applied the equivalent fix to 3_0_BRANCH ages ago.
>
> - --
> Neil Stevens - neil@qualityassistant.com
> "I always cheer up immensely if an attack is particularly wounding
> because I think, well, if they attack one personally, it means they
> have not a single political argument left." - Margaret Thatcher
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.0.6 (GNU/Linux)
> Comment: For info see http://www.gnupg.org
>
> iD8DBQE9co0Ff7mnligQOmERAnuUAKCUzWulc24+qmxLvbezuyhMlX/2MwCfbLF+
> ntT+DSyiu++h9ldoNDTCu3Y=
> =Fz6C
> -----END PGP SIGNATURE-----

[prev in list] [next in list] [prev in thread] [next in thread]