[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/libkonq
From:       John Firebaugh <jfirebaugh () kde ! org>
Date:       2002-07-18 16:12:09
[Download RAW message or body]

On Thursday 18 July 2002 8:58, Carsten Pfeiffer wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
>
> On Thursday 18 July 2002 17:40, John Firebaugh wrote:
> > This seems to solve the simple case of storing entries case-insensitively
> > in the sidebar view. You are saying it will break other things?
>
> I don't know about the sidebar view, but khtml will get wrong results when
> asking the history provider whether a url is already visited or not. What
> does your change fix in the sidebar?

If you visit pages at http://www.kde.org/ and http://WWW.KDE.ORG/, they will 
all appear under the history entry for www.kde.org.

> > > Even if KURL::operator==( const KURL& ) compares the host part case
> > > insensitively (does it?), this would unfortunately not be enough.
> >
> > It doesn't. Perhaps it should, though. Then KonqHistoryList::findEntry()
> > would work better.
>
> It really should.

I will fix it.

> > > KParts::HistoryProvider is QString based and not KURL based, due to
> > > performance reasons (ask Lars for details). E.g.
> > >
> > > bool KParts::HistoryProvider::contains( const QString& item ) const
> > >
> > > would most probably break, as a url http://www.KDE.org would not be
> > > found in the history anymore.
> >
> > The comments in konq_historymgr.cc led me to believe that the
> > KParts::HistoryProvider implementation stored only local items (without
> > hostname).
>
> It stores only local items though the insert() method. Lookup with the
> contains() method happens for all items tho. KonqHistoryProvider doesn't
> reimplement contains(). If it would, to perform case insensitive lookup,
> then it had to create a KURL which would slow down khtml again.

Well, I'm confused. If only local items are insert()ed, how can we call 
contains() for any item?

-John
[prev in list] [next in list] [prev in thread] [next in thread]