[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: koffice/kspread/templates/General
From:       David Faure <david () mandrakesoft ! com>
Date:       2002-07-04 10:50:02
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 04 July 2002 12:40, Werner Trobin wrote:
> On Thursday 04 July 2002 12:29, David Faure wrote:
> > On Thursday 04 July 2002 11:46, Laurent Montel wrote:
> > > koffice/kspread/templates/General Worksheet.kst,1.1,1.2
> > > Author: mlaurent
> > >
> > >
> > > Modified Files:
> > >          Worksheet.kst
> > > Log Message:
> > > Change template : don't save documentinfo.xml and
> > > locale in this template.
> > > We can't change koCreateTemplateDia :(
> > > otherwise I will add a checkbox to say :
> > > -> add documentInfo
> > > -> add locale for kspread.
> > >
> > > So for koffice 1.3
> > 
> > Or we could assume that we never want this in a template
> > (documentinfo is a property of the document, not of the template,
> > and the locale is taken from the user's settings anyway),
> > and then all we need is a way to tell the application that it's saving
> > a template. Maybe a new specialOutputFlag() in koDocument.h,
> > SaveTemplate?
> 
> I think if a user wants to save a template it's perfectly okay to have the 
> document information included. If we (as in KOffice developers) want to add a 
> new template to CVS it's no problem for us to remove the offending 
> information manually IMHO.

There are tons of other people who create templates. Companies, people
who send us templates, etc. Plus, people might send each other templates,
and then the name in the documentinfo will be wrong....

Ah. I was assuming the kofficerc info was saved into the doc automatically,
but it isn't - the user has to open the document info dialog to have it pre-filled.

Hmm. I still don't see much point in saving the documentinfo in the template
though. Better have an "auto-fill document info" (checkbox in the config,
which means the documentinfo is auto filled in when saving the document),
but I can see people screaming about security issues already
(although IMHO saving the documentinfo into the template is the same
kind of issue, possibly even worse)...

- -- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
KOffice-1.2-beta2 is out! http://dot.kde.org/1025176121/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9JCha72KcVAmwbhARAqqdAJ9/cXHykurG3MiTwOKhZju+xnPGpQCeLB61
xJphm4nNpzQUmMOoFqeD1B4=
=cAyn
-----END PGP SIGNATURE-----

[prev in list] [next in list] [prev in thread] [next in thread]