[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kdeui
From:       Joseph Wenninger <jowenn () jowenn ! at>
Date:       2002-06-30 10:57:07
[Download RAW message or body]

Hi

On Saturday 29 June 2002 15:04, Bernd Gehrmann wrote:
> On Thu, 27 Jun 2002, David Faure wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > On Thursday 27 June 2002 11:29, Bernd Gehrmann wrote:
> > > kdelibs/kdeui kmainwindow.cpp,1.74,1.75 kstdaction.cpp,1.70,1.71
> > > Author: gehrmab
> > >
> > >
> > > Modified Files:
> > >          kmainwindow.cpp kstdaction.cpp
> > > Log Message:
> > > Last time I checked, the policy was that kdelibs stays compatible
> > > during 3.0 Overriding application actions and renaming standard actions
> > > is definitely not compatible
> >
> > Hmm, this change was done in a "compatible way", since apps didn't need
> > to be changed, and would automatically benefit from the new submenu for
> > toolbars.
>
> Benefit? Their behavior is changed, nothing else. When an application
> programmer writes code like
>
>   KStdAction::configureToolbars(parent, SLOT(mySlot()), actionCollection)
>     ->setToolTip("mytooltip")
>
> he wants mySlot() to be called when the action is activated, not some
> other slot. He also wants the action to have the tooltip "mytooltip",
> and not another one. Why do kdelibs people think that they are smarter
> than application programmers and are allowed to change the behavior
> of application programs through some backdoors?
>
> Bernd.

Why configureToolbars ?? The only affected action is KStdAction::showToolbar. 
I see your problem and will fix it soon.

Kind regards
Joseph Wenninger

[prev in list] [next in list] [prev in thread] [next in thread]