[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdenonbeta/kopete/kopete/protocols/msn
From:       Martijn Klingens <mklingens () yahoo ! com>
Date:       2002-04-09 20:12:00
[Download RAW message or body]


kdenonbeta/kopete/kopete/protocols/msn msnaddcontactpage.cpp,1.6,1.7 \
                msncontact.cpp,1.21,1.22 msnprotocol.cpp,1.33,1.34 \
                msnprotocol.h,1.19,1.20
Author: mklingens
Tue Apr  9 22:12:00 CEST 2002
In directory office:/tmp/cvs-serv32263


Modified Files:
         msnaddcontactpage.cpp msncontact.cpp msnprotocol.cpp
         msnprotocol.h
Log Message:
Refactoring MSN, step 1:
- Make all data members private. Only engine was accessed from outside the
  class (eek! :). engine is now accessible through the member function
  msnService(), although it might be a good idea to have wrappers in
  MSNProtocol for the few things it needs to provide to the outside world.
  That's for later, though. The idea behind refactoring is to take _small_
  steps and keep the code compilable and runnable at any time :-)
- See above, renamed engine to m_msnService with accessor msnService()
- Reordered the function definitions. This last change means that anyone with
  local changes to msnprotocol.h will almost certainly end up with conflicts.
  Sorry, but it has to be done some day...


[prev in list] [next in list] [prev in thread] [next in thread]