[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/kicker/extensions/childpanel
From:       "Wilco Greven" <j.w.greven () student ! utwente ! nl>
Date:       2002-03-15 16:29:29
[Download RAW message or body]

On Fri, Mar 15, 2002 at 08:13:28AM -0800, John Firebaugh wrote:
> On Friday 15 March 2002 4:59, Wilco Greven wrote:
> > kdebase/kicker/extensions/childpanel childpanelextension.cpp,1.24,1.25
> > Author: wgreven
> > Fri Mar 15 13:59:54 CET 2002
> > In directory office:/tmp/cvs-serv17048
> >
> >
> > Modified Files:
> >          childpanelextension.cpp
> > Log Message:
> > Index: childpanelextension.cpp
> > ===================================================================
> > RCS file:
> > /home/kde/kdebase/kicker/extensions/childpanel/childpanelextension.cpp,v
> > retrieving revision 1.24
> > diff -u -p -b -r1.24 childpanelextension.cpp
> > --- childpanelextension.cpp	2002/03/02 19:59:45	1.24
> > +++ childpanelextension.cpp	2002/03/15 12:59:29
> > @@ -100,6 +100,10 @@ ChildPanelExtension::ChildPanelExtension
> >      KConfig* c = config();
> >      c->setGroup("General");
> >      _size = c->readNumEntry("Size", 1);
> > +
> > +    // Make sure the containerarea has the right orientation from the
> > +    // beginning.
> > +    positionChange(position());
> >  }
> >
> >  ChildPanelExtension::~ChildPanelExtension()
> 
> This shouldn't be necessary. Are you sure you don't have the "kicker finds old 
> libraries" problem instead?

Yes, I updated kdeui and kicker. The problem here is that if you have a
childpanel at the top of the screen, postionChange() isn't called. It only
happens when it is at the top because KPanelExtension sets _position to Top
by default. Because positioChange() isn't called, the childpanel's
containerarea isn't initialized correctly.

-- 
Greetings,
Wilco
> 
[prev in list] [next in list] [prev in thread] [next in thread]