[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kstyles/themes
From:       Stephan Kulow <coolo () kde ! org>
Date:       2002-01-22 14:00:39
[Download RAW message or body]

On Tuesday, 22. January 2002 14:29, Maks Orlovich wrote:
> On Tuesday 22 January 2002 07:40 am, Stephan "The Bot" Kulow wrote:
> > kdelibs/kstyles/themes kthemestylerc,NONE,1.1 Makefile.am,1.25,1.26
> > kthemestylerc.in,1.1,NONE Author: kulow
> > Tue Jan 22 12:40:07 UTC 2002
> >
> >
> > Modified Files:
> >          Makefile.am
> > Added Files:
> >          kthemestylerc
> > Removed Files:
> >          kthemestylerc.in
> > Log Message:
> > I couldn't find the place where this rc file is used, but the way it hard
> > codes paths is a big nono within KDE.
>
> The file is used in KThemeStyle, and the reason it's used is that the
> styles can't link to kdecore -- that's probably why you couldn't find
> references to it, since it's used through QSettings and not KConfig.  I
> could probably use a minimal implementation I have in KStyleDirs, but that
> removes some of the benefits of using this cache with respect to app
> startup.. Thanks for the kde_conf_DATA bit, BTW...

OUCH! KStyleDirs is a copycat of KStandardDirs. I would very much prefer it 
to be removed and replaced it with well placed calls to kde-config. I can 
also add code to kde-config that calls locate then. 
E.g. call kde-config --type data kstyles/themes/marble.themerc

Greetings, Stephan
[prev in list] [next in list] [prev in thread] [next in thread]