[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/konqueror/iconview
From:       Martijn Klingens <mklingens () yahoo ! com>
Date:       2001-11-30 23:21:00
[Download RAW message or body]

On Friday 30 November 2001 17:55, David Faure wrote:
> > > The (new?) iconset cache in KFileIVI had a bad side effect on icons
> > > with a delayed mimetype determination - after a mouse over, the icon
> > > would reset to the 'unknown' icon.
> >
> > New? Unless it has been rewritten recently I wouldn't call it 'new'
> > anymore, as I wrote this for KDE 2.2.
>
> Yes that's what I thought...
> But then I don't understand why this bug only showed up so recently.
> Did you ever notice it ? (see below)

Nope, that's the reason for my rather surprised reply to your commit :-)

> > Given your CVS log this could very well be the case in 2.2 as well.
>
> I don't remember seeing this bug back then. Something must have triggered
> it more recently.

Maybe the delayed mimetypes are triggered later? Were they triggered at all 
in 2.2?

> Very simple. Take a C++ file and rename it "blah".
> Since it has no known extension, its icon will initially be "unknown" and
> will then become very quickly the cpp-text-file one. Then, with icon
> effects activated, move the mouse over it, and then out of it. At this
> point, it used to (in kde cvs, for the last 2-3 weeks) revert to the

*trying* (those kde2run and kde3run shellscripts I wrote are really useful to 
run single apps from the 'wrong' KDE version btw, would there be a need in 
kdesdk/scripts?)

Hmm... I have a dir now with a c++ file and a copy of the file without 
extension. In KDE 3 I can reproduce your bug, but with 2.2 Konq the bug does 
_NOT_ manifest itself!

> unknown icon. Not surprising given the current code, but I don't understand
> why this didn't happen in 2.2.

Me neither. This must have been outside the KFileIVI - or there have been 
commits to KFileIVI that we were both unaware of...

Martijn

PS: Even if the bug was in KDE 2.2, I might very well never have noticed it 
since I always run with all previews enabled, and not much files that don't 
have previews fall in the delayed mime type category. But that's not really 
an issue here - the bug really isn't there in KDE 2.2

[prev in list] [next in list] [prev in thread] [next in thread]