[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kio
From:       David Faure <david () mandrakesoft ! com>
Date:       2001-11-18 19:31:20
[Download RAW message or body]

On Sunday 18 November 2001 18:46, Michael Brade wrote:
> On Friday 16 November 2001 23:04, Waldo Bastian wrote:
> > kdelibs/kio kdirlister.cpp,1.74,1.75 kdirlister.h,1.33,1.34
> > Author: waba
> > Fri Nov 16 22:03:41 UTC 2001
> >
> >
> > Modified Files:
> >          kdirlister.cpp kdirlister.h
> > Log Message:
> > Ready for KDE 3.0
> No, not really ;-) Caching is still missing and will cause quite some API 
> change.
> 
> And I have just a curious question:
> 
> -   * If many jobs are concurrently running, this returns one of the currently
> -   * running jobs (!).
> +   * Returns the job currently running, if there is one and only one job
> +   * running. Otherwise 0 is returned.
>     */
> -  KIO::ListJob * job() const { return m_job; }
> +  KIO::ListJob * job() const;
> 
> Why? Like this we won't get a status bar message if opening two or more dirs 
> in the treeview. OTOH I can't think of a clean solution right now and it 
> makes things simpler, so... :)

I thought this was what you wanted, so I advised Waldo to go that way :}
What else could we do anyway ? Return the "first" job (in the map, or
chronologically) ? Doesn't sound very clean either. 0 looks cleaner in terms
of API.
 
-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://perso.mandrakesoft.com/~david/ , http://www.konqueror.org/
KDE 3.0: Konquering the Desktops

[prev in list] [next in list] [prev in thread] [next in thread]