[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kio/klauncher
From:       Simon Hausmann <hausmann () kde ! org>
Date:       2001-11-15 15:59:41
[Download RAW message or body]

On Thu, Nov 15, 2001 at 12:20:41PM +0100, David Faure wrote:
> On Thursday 15 November 2001 09:57, Simon Hausmann wrote:
> > kdelibs/kio/klauncher klauncher.cpp,1.62,1.63
> > Author: hausmann
> > Thu Nov 15 08:56:49 UTC 2001
> > 
> > 
> > Modified Files:
> >          klauncher.cpp
> > Log Message:
> > +      // work around braindead QApplication mutex handling
> > +      if (kapp->locked())
> > +         kapp->unlock(false);
> >        delete kapp;
> 
> Clueless comment: isn't this something that should be done by
> ~QApplication or ~KApplication then ?

I fully agree. IMHO it belongs into ~QApplication, but given that
the current (IMHO braindead) behaviour is even documented it looks
like they had a reason.

I find this behaviour stupid because it requires an application
developer to put an #ifdef QT_THREAD_SUPPORT in his source if he 
wants his non-threaded application to run with and without qt-mt.
Any Troll listening, possibly enlightening us about the reasoning?
:-}


Simon

[prev in list] [next in list] [prev in thread] [next in thread]