[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/konqueror
From:       David Faure <david () mandrakesoft ! com>
Date:       2001-11-13 0:17:58
[Download RAW message or body]

On Mardi 13 Novembre 2001 00:58, Alexander Neundorf wrote:
> kdebase/konqueror konq_mainwindow.cc,1.922,1.923
> Author: neundorf
> Mon Nov 12 23:58:11 UTC 2001
> 
> 
> Modified Files:
> konq_mainwindow.cc
> Log Message:
> 
> in slotReload():
> 
> -  openURL( m_currentView, m_currentView->url(), QString::null /* the
> servicetype may have changed */, req );
> +  // Reuse current servicetype for local files, but not for remote files (it could \
> have changed, e.g. over HTTP) +  QString serviceType = \
> m_currentView->url().isLocalFile() ? m_currentView->serviceType() : QString::null; \
> +  openURL( m_currentView, m_currentView->url(), serviceType, req );
Yup, as discussed.

> in openView():
> else // We know the child view
> {
> //childView->stop();
> +      //childView->stop();
> +       if (childView->serviceType()==serviceType)
> +          ok=true;
> +       else
> ok = childView->changeViewMode( serviceType, serviceName );
> }
> 
> this should save the searching for a matching part if we are simply
> reloading

Shouldn't you test the serviceName too ? One can choose a different service
for the same type (e.g. iconview, listview and textview are all services
for inode/directory). I would suggest
if ( childView->serviceType() == serviceType && childView->serviceName() == \
serviceName ) unless there are some special uses of empty strings to mean "any".... \
to be checked.

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://perso.mandrakesoft.com/~david/ , http://www.konqueror.org/
KDE 3.0: Konquering the Desktops


[prev in list] [next in list] [prev in thread] [next in thread]