[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kdecore
From:       Hans Petter Bieker <bieker () stud ! ntnu ! no>
Date:       2001-10-17 12:09:42
[Download RAW message or body]

On Mon, 15 Oct 2001, David Faure wrote:

> On Lundi 15 Octobre 2001 11:13, Martijn Klingens wrote:
> > On Monday 15 October 2001 10:55, David Faure wrote:
> > > On Lundi 15 Octobre 2001 10:13, Hans Petter Bieker wrote:
> > > > On Wed, 10 Oct 2001, CVS by faure wrote:
> > > > > Improved error checking when looking at thousands separators in
> > > > > readNumber and readDate. 2,34 isn't 234 anymore, but 2,345 is 2345.
> > > >
> > > > So what is it? Do you just return 0.0F and set *ok = false?
> > >
> > > For "2,34" ? Yes.
> > > KSpread relies on that, to make it remain text instead of becoming a
> > > number.
> >
> > But in Dutch locale "2,34" is the proper spelling of 2.34F...
>
> I was speaking about the thousands separator !
> Martijn, please, read the code before commenting.

BTW: Do you now require the user to write thousands sperators?
Is this legal:
1) 12,1
2) 12,100
3) 12,100000,000
4) 12100000000
5) 12100000,000
6) 12100000000
7) 12,,100,000
8) 12,1000,000
9) 12,0000000,000

I guess 2, 4 and 6 should be legal, the rest should be illegal.

I can't test it here, but I think your code fails to do the right thing
on 3, 5 and 7. (they should not be legal.)

Can you verify that?

Norwegian University of Science and Technology, Engineering Cybernetics
          bieker@stud.ntnu.no / bieker@kde.org / +47 97651633
                Dagaliveien 25 A  |  Elgesetergate 23 B
                N-0776 Oslo       |  N-7030 Trondheim
  Siste nytt fra industrien finner du på: WWW.Industri-Informasjon.NO

[prev in list] [next in list] [prev in thread] [next in thread]