[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-buildsystem
Subject:    Re: Review Request 128779: Teach KDECompilerSettings about clang-cl,  a mode of Clang compiler that 
From:       Albert Astals Cid <aacid () kde ! org>
Date:       2017-02-04 11:05:58
Message-ID: 20170204110558.23300.86309 () mimi ! kde ! org
[Download RAW message or body]

--===============4148509245287592763==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128779/#review102364
-----------------------------------------------------------



Patch doesn't apply anymore

- Albert Astals Cid


On Oct. 12, 2016, 11:57 a.m., Gleb Popov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128779/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2016, 11:57 a.m.)
> 
> 
> Review request for Extra Cmake Modules and kdewin.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> By simply using `if(CMAKE_COMPILER_ID STREQUAL "Clang")` check is not enough for \
> clang-cl, as it turns on various '-style' flags and omits MSVC's '/style' flags. 
> With this patch i managed to compile much of KF5 up to konversation and kate.
> 
> Known problems: `-std=gnu++98` flag is still appended, but i wasn't able to figure \
> out why. 
> 
> Diffs
> -----
> 
> kde-modules/KDECompilerSettings.cmake dfa29f7 
> kde-modules/KDEFrameworkCompilerSettings.cmake 038ddc3 
> 
> Diff: https://git.reviewboard.kde.org/r/128779/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gleb Popov
> 
> 


--===============4148509245287592763==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128779/">https://git.reviewboard.kde.org/r/128779/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Patch \
doesn't apply anymore</p></pre>  <br />









<p>- Albert Astals Cid</p>


<br />
<p>On October 12th, 2016, 11:57 a.m. UTC, Gleb Popov wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Extra Cmake Modules and kdewin.</div>
<div>By Gleb Popov.</div>


<p style="color: grey;"><i>Updated Oct. 12, 2016, 11:57 a.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">By simply using <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">if(CMAKE_COMPILER_ID STREQUAL "Clang")</code> check is not enough for \
clang-cl, as it turns on various '-style' flags and omits MSVC's '/style' flags.</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">With this patch i managed to compile much of KF5 up to \
konversation and kate.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Known problems: <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">-std=gnu++98</code> flag is still appended, but i wasn't \
able to figure out why.</p></pre>  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kde-modules/KDECompilerSettings.cmake <span style="color: \
grey">(dfa29f7)</span></li>

 <li>kde-modules/KDEFrameworkCompilerSettings.cmake <span style="color: \
grey">(038ddc3)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128779/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>


--===============4148509245287592763==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic