From kde-buildsystem Sat Feb 04 11:01:09 2017 From: Stephen Kelly Date: Sat, 04 Feb 2017 11:01:09 +0000 To: kde-buildsystem Subject: Re: Review Request 127440: Revert "ECMQtDeclareLoggingCategory: Include with the generated Message-Id: <20170204110109.9908.25371 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-buildsystem&m=148620607503491 --===============8558476655743030323== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127440/ ----------------------------------------------------------- (Updated Feb. 4, 2017, 11:01 a.m.) Status ------ This change has been marked as submitted. Review request for Extra Cmake Modules, Alex Merry and Martin Klapetek. Repository: extra-cmake-modules Description ------- The original review request doesn't say what concrete problem led to this being added: https://git.reviewboard.kde.org/r/126368/ QLoggingCategory has always included QDebug, so this has always been superfluous. Diffs ----- modules/ECMQtDeclareLoggingCategory.cmake 3f7bb79 modules/ECMQtDeclareLoggingCategory.h.in b59bc7a Diff: https://git.reviewboard.kde.org/r/127440/diff/ Testing ------- None. Thanks, Stephen Kelly --===============8558476655743030323== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127440/

This change has been marked as submitted.

Review request for Extra Cmake Modules, Alex Merry and Martin Klapetek.
By Stephen Kelly.

Updated Feb. 4, 2017, 11:01 a.m.

Repository: extra-cmake-modules

Description 

The original review request doesn't say what concrete problem led to this being added: https://git.reviewboard.kde.org/r/126368/


QLoggingCategory has always included QDebug, so this has always been superfluous.

Testing 

None.

Diffs

  • modules/ECMQtDeclareLoggingCategory.cmake (3f7bb79)
  • modules/ECMQtDeclareLoggingCategory.h.in (b59bc7a)

View Diff
--===============8558476655743030323==--