From kde-buildsystem Thu Jan 05 20:31:42 2017 From: Stephen Kelly Date: Thu, 05 Jan 2017 20:31:42 +0000 To: kde-buildsystem Subject: Re: Review Request 129765: Handle the case of an enum with visibility attributes. Message-Id: <20170105203142.13774.14953 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-buildsystem&m=148364830701251 --===============6570815457014436055== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129765/#review101825 ----------------------------------------------------------- Ship it! Perfect, thanks! I've cherry-picked (not merged) this and pushed it to master. - Stephen Kelly On Jan. 5, 2017, 8:31 a.m., Shaheed Haque wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129765/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2017, 8:31 a.m.) > > > Review request for Extra Cmake Modules. > > > Repository: extra-cmake-modules > > > Description > ------- > > The problem can be seen in the wild in, for example, > KActivitiesStats/kactivitiesstats/cleaning.h > > > Diffs > ----- > > find-modules/sip_generator.py 10be147711540437d38153fa8fe859bd34d7aa6c > tests/GenerateSipBindings/cpplib.h 0d63c30ed52b5d817c233e358b1ebce7a70c8218 > tests/GenerateSipBindings/testscript.py 6f2132a2282208d914c0d5685fc78cf69e747b5e > > Diff: https://git.reviewboard.kde.org/r/129765/diff/ > > > Testing > ------- > > $ make test > Running tests... > Test project /home/.../extra-cmake-modules > Start 1: GenerateSipBindings > 1/49 Test #1: GenerateSipBindings ................................... Passed 8.59 sec > Start 2: ExecuteCoreModules > 2/49 Test #2: ExecuteCoreModules .................................... Passed 0.46 sec > Start 3: ExecuteKDEModules > > > Thanks, > > Shaheed Haque > > --===============6570815457014436055== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129765/

Ship it! 

Perfect, thanks! I've cherry-picked (not merged) this and pushed it to master.

- Stephen Kelly


On January 5th, 2017, 8:31 a.m. UTC, Shaheed Haque wrote:

Review request for Extra Cmake Modules.
By Shaheed Haque.

Updated Jan. 5, 2017, 8:31 a.m.

Repository: extra-cmake-modules

Description 

The problem can be seen in the wild in, for example,
KActivitiesStats/kactivitiesstats/cleaning.h

Testing 

$ make test
Running tests...
Test project /home/.../extra-cmake-modules
      Start  1: GenerateSipBindings
 1/49 Test  #1: GenerateSipBindings ...................................   Passed    8.59 sec
      Start  2: ExecuteCoreModules
 2/49 Test  #2: ExecuteCoreModules ....................................   Passed    0.46 sec
      Start  3: ExecuteKDEModules

Diffs

  • find-modules/sip_generator.py (10be147711540437d38153fa8fe859bd34d7aa6c)
  • tests/GenerateSipBindings/cpplib.h (0d63c30ed52b5d817c233e358b1ebce7a70c8218)
  • tests/GenerateSipBindings/testscript.py (6f2132a2282208d914c0d5685fc78cf69e747b5e)

View Diff
--===============6570815457014436055==--