[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-buildsystem
Subject: Re: Review Request 129708: C project also need Clang Sanitizer
From: Albert Astals Cid <aacid () kde ! org>
Date: 2016-12-29 17:08:01
Message-ID: 20161229170801.23879.92473 () mimi ! kde ! org
[Download RAW message or body]
--===============2473390022913451693==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129708/#review101656
-----------------------------------------------------------
Ship it!
Maybe you can add a TODO to investigate it for gcc?
- Albert Astals Cid
On Dec. 29, 2016, 2:48 a.m., Leslie Zhai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129708/
> -----------------------------------------------------------
>
> (Updated Dec. 29, 2016, 2:48 a.m.)
>
>
> Review request for Extra Cmake Modules and Alex Merry.
>
>
> Bugs: 374195
> http://bugs.kde.org/show_bug.cgi?id=374195
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> So I just added
>
> ```
> set( CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${XSAN_COMPILE_FLAGS}" )
> ```
>
> for C project to use Clang Sanitizer.
>
>
> Diffs
> -----
>
> modules/ECMEnableSanitizers.cmake 9c8a4de
>
> Diff: https://git.reviewboard.kde.org/r/129708/diff/
>
>
> Testing
> -------
>
> testcase for Clang Static Analyzer, and also for Clang Sanitizer \
> https://github.com/LLVM-China/clang-analyzer.github.io/tree/master/tests
> ```
> cmake .. -DCMAKE_C_COMPILER=clang \
> -DCMAKE_CXX_COMPILER=clang++ \
> -DECM_ENABLE_SANITIZERS='address;leak;undefined' \
> -DCMAKE_BUILD_TYPE=Debug
> ```
>
> testcase for kcoreaddons and kjs with GNU compiler
>
> ```
> cmake .. -DCMAKE_INSTALL_PREFIX=/usr \
> -DECM_ENABLE_SANITIZERS='address;leak;undefined' \
> -DKDE_INSTALL_LIBDIR=lib \
> -D_KDE4_DEFAULT_HOME_POSTFIX=4 \
> -DBUILD_TESTING=ON
> ```
>
> ```
> cmake .. -DCMAKE_INSTALL_PREFIX=/usr \
> -DECM_ENABLE_SANITIZERS='address;leak;undefined' \
> -DKDE_INSTALL_LIBDIR=lib \
> -DBUILD_TESTING=ON
> ```
>
>
> Thanks,
>
> Leslie Zhai
>
>
--===============2473390022913451693==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129708/">https://git.reviewboard.kde.org/r/129708/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Maybe \
you can add a TODO to investigate it for gcc?</p></pre> <br />
<p>- Albert Astals Cid</p>
<br />
<p>On December 29th, 2016, 2:48 a.m. UTC, Leslie Zhai wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Extra Cmake Modules and Alex Merry.</div>
<div>By Leslie Zhai.</div>
<p style="color: grey;"><i>Updated Dec. 29, 2016, 2:48 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=374195">374195</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">So I just added</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div \
class="codehilite" style="background: #f8f8f8"><pre style="line-height: \
125%"><span></span>set( CMAKE_C_FLAGS "<span style="color: \
#BC7A00">${</span>CMAKE_C_FLAGS<span style="color: #BC7A00">}</span> <span \
style="color: #BC7A00">${</span>XSAN_COMPILE_FLAGS<span style="color: \
#BC7A00">}</span>" ) </pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">for C project to use Clang Sanitizer.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">testcase for Clang Static Analyzer, and also for Clang \
Sanitizer https://github.com/LLVM-China/clang-analyzer.github.io/tree/master/tests</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><div class="codehilite" style="background: \
#f8f8f8"><pre style="line-height: 125%"><span></span>cmake .. \
-DCMAKE_C_COMPILER=clang \ \
-DCMAKE_CXX_COMPILER=clang++ \
-DECM_ENABLE_SANITIZERS='address;leak;undefined' \ \
-DCMAKE_BUILD_TYPE=Debug
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">testcase for kcoreaddons and kjs with GNU compiler</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><div class="codehilite" style="background: \
#f8f8f8"><pre style="line-height: 125%"><span></span>cmake .. \
-DCMAKE_INSTALL_PREFIX=/usr \ \
-DECM_ENABLE_SANITIZERS='address;leak;undefined' \ \
-DKDE_INSTALL_LIBDIR=lib \
-D_KDE4_DEFAULT_HOME_POSTFIX=4 \
-DBUILD_TESTING=ON
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><div class="codehilite" style="background: \
#f8f8f8"><pre style="line-height: 125%"><span></span>cmake .. \
-DCMAKE_INSTALL_PREFIX=/usr \ \
-DECM_ENABLE_SANITIZERS='address;leak;undefined' \ \
-DKDE_INSTALL_LIBDIR=lib \
-DBUILD_TESTING=ON
</pre></div>
</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>modules/ECMEnableSanitizers.cmake <span style="color: \
grey">(9c8a4de)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129708/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2473390022913451693==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic