'Re: Review Request 127440: Revert "ECMQtDeclareLoggingCategory: Include <QDebug> with the generated '

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-buildsystem
Subject:    Re: Review Request 127440: Revert "ECMQtDeclareLoggingCategory: Include <QDebug> with the generated 
From:       Martin Klapetek <martin.klapetek () gmail ! com>
Date:       2016-03-21 15:17:09
Message-ID: 20160321151709.21226.66476 () mimi ! kde ! org
[Download RAW message or body]

--===============6008255382508984796==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127440/#review93823
-----------------------------------------------------------

Ship it!

I don't remember what trouble there was with this but looks not needed indeed.

- Martin Klapetek

On March 20, 2016, 7:46 p.m., Stephen Kelly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127440/
> -----------------------------------------------------------
> 
> (Updated March 20, 2016, 7:46 p.m.)
> 
> 
> Review request for Extra Cmake Modules, Alex Merry and Martin Klapetek.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> The original review request doesn't say what concrete problem led to this being \
> added: https://git.reviewboard.kde.org/r/126368/ 
> 
> QLoggingCategory has always included QDebug, so this has always been superfluous.
> 
> 
> Diffs
> -----
> 
> modules/ECMQtDeclareLoggingCategory.cmake 3f7bb79 
> modules/ECMQtDeclareLoggingCategory.h.in b59bc7a 
> 
> Diff: https://git.reviewboard.kde.org/r/127440/diff/
> 
> 
> Testing
> -------
> 
> None.
> 
> 
> Thanks,
> 
> Stephen Kelly
> 
> 

--===============6008255382508984796==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127440/">https://git.reviewboard.kde.org/r/127440/</a>
  </td>
    </tr>
   </table>
   <br />

<p>

Ship it!

</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
don't remember what trouble there was with this but looks not needed \
indeed.</p></pre>  <br />

<p>- Martin Klapetek</p>

<br />
<p>On March 20th, 2016, 7:46 p.m. CET, Stephen Kelly wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Extra Cmake Modules, Alex Merry and Martin Klapetek.</div>
<div>By Stephen Kelly.</div>

<p style="color: grey;"><i>Updated March 20, 2016, 7:46 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The original review request doesn't say what concrete \
problem led to this being added: https://git.reviewboard.kde.org/r/126368/</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">QLoggingCategory has always included QDebug, so this has always been \
superfluous.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">None.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>modules/ECMQtDeclareLoggingCategory.cmake <span style="color: \
grey">(3f7bb79)</span></li>

 <li>modules/ECMQtDeclareLoggingCategory.h.in <span style="color: \
grey">(b59bc7a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127440/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6008255382508984796==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

[prev in list] [next in list] [prev in thread] [next in thread] 