[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-buildsystem
Subject: Re: Review Request 126648: Allow to disable KArchive for internal usage
From: "Luigi Toscano" <luigi.toscano () tiscali ! it>
Date: 2016-01-06 21:33:53
Message-ID: 20160106213353.6499.28855 () mimi ! kde ! org
[Download RAW message or body]
--===============1724477353334062133==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Gen. 6, 2016, 8:33 a.m., David Faure wrote:
> > src/xslt_kde.cpp, line 17
> > <https://git.reviewboard.kde.org/r/126648/diff/1/?file=428563#file428563line17>
> >
> > I would suggest to add a qWarning() under this line, to warn at runtime in case \
> > this is ever called in a non-karchive build.
Thanks; I'm going to update the patch for reference, then push it after the release \
of Frameworks 5.18.
- Luigi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126648/#review90682
-----------------------------------------------------------
On Gen. 6, 2016, 1:58 a.m., Luigi Toscano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126648/
> -----------------------------------------------------------
>
> (Updated Gen. 6, 2016, 1:58 a.m.)
>
>
> Review request for Build System, KDE Frameworks, Alex Merry, and David Faure.
>
>
> Repository: kdoctools
>
>
> Description
> -------
>
> Most of the code was already prepared to compile without the KArchive dependency \
> (including the MEINPROC_NO_KARCHIVE flag). This mode should be only enabled on KDE \
> infrastructure, as the compressed cache (the only added feature coming from \
> KArchive) is not used by the generator of the documentation website. A warning is \
> printed when the mode is enabled. The saveToCache function is preserved, even if \
> without code, to minimize the changes required.
>
> Diffs
> -----
>
> CMakeLists.txt 2ec3027
> src/CMakeLists.txt 136fbfb
> src/xslt_kde.cpp 7069a28
>
> Diff: https://git.reviewboard.kde.org/r/126648/diff/
>
>
> Testing
> -------
>
> Normal compilation, compilation with MEINPROC_NO_KARCHIVE=ON
>
>
> Thanks,
>
> Luigi Toscano
>
>
--===============1724477353334062133==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126648/">https://git.reviewboard.kde.org/r/126648/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On gennaio 6th, 2016, 8:33 a.m. CET, <b>David \
Faure</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/126648/diff/1/?file=428563#file428563line17" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/xslt_kde.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">17</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#else</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
would suggest to add a qWarning() under this line, to warn at runtime in case this is \
ever called in a non-karchive build.</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Thanks; I'm going to update the patch for reference, then push it after the \
release of Frameworks 5.18.</p></pre> <br />
<p>- Luigi</p>
<br />
<p>On gennaio 6th, 2016, 1:58 a.m. CET, Luigi Toscano wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Build System, KDE Frameworks, Alex Merry, and David \
Faure.</div> <div>By Luigi Toscano.</div>
<p style="color: grey;"><i>Updated Gen. 6, 2016, 1:58 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdoctools
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Most of the code was already prepared to compile without the KArchive \
dependency (including the MEINPROC_NO_KARCHIVE flag). This mode should be only \
enabled on KDE infrastructure, as the compressed cache (the only added feature coming \
from KArchive) is not used by the generator of the documentation website. A warning \
is printed when the mode is enabled. The saveToCache function is preserved, even if \
without code, to minimize the changes required.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Normal compilation, compilation with MEINPROC_NO_KARCHIVE=ON</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(2ec3027)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(136fbfb)</span></li>
<li>src/xslt_kde.cpp <span style="color: grey">(7069a28)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126648/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1724477353334062133==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic