[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-buildsystem
Subject: Re: Review Request 126546: Fix CMP0064 warning by setting policy CMP0054 to NEW.
From: "David Faure" <faure () kde ! org>
Date: 2015-12-28 22:37:02
Message-ID: 20151228223702.23737.28648 () mimi ! kde ! org
[Download RAW message or body]
--===============7801034161192311705==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126546/
-----------------------------------------------------------
(Updated Dec. 28, 2015, 10:37 p.m.)
Status
------
This change has been marked as submitted.
Review request for Build System and Alex Merry.
Changes
-------
Submitted with commit 628aec760177891e040bb1d6c66958bbdb33e681 by David Faure to \
branch master.
Repository: kdelibs4support
Description
-------
This isn't a typo: if CMP0054 is set, then "TEST" is not parsed
as TEST, and the CMP0064 warning doesn't trigger. Or something like that.
cmake isn't getting any simpler.
Diffs
-----
cmake/modules/KDE4Macros.cmake 1c41550eaf79cf908c0e34cef7a6aa36bec56aab
Diff: https://git.reviewboard.kde.org/r/126546/diff/
Testing
-------
Applied the same to kdelibs4 and it fixes the warning when compiling one of my \
kde4-based apps (fatcrm).
Thanks,
David Faure
--===============7801034161192311705==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126546/">https://git.reviewboard.kde.org/r/126546/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Build System and Alex Merry.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2015, 10:37 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 628aec760177891e040bb1d6c66958bbdb33e681 by David \
Faure to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs4support
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This isn't a typo: if CMP0054 is set, then "TEST" is not \
parsed as TEST, and the CMP0064 warning doesn't trigger. Or something like that.
cmake isn't getting any simpler.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Applied the same to kdelibs4 and it fixes the warning \
when compiling one of my kde4-based apps (fatcrm).</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/KDE4Macros.cmake <span style="color: \
grey">(1c41550eaf79cf908c0e34cef7a6aa36bec56aab)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126546/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7801034161192311705==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic