[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-buildsystem
Subject: Re: Review Request 126535: Silence CMP0063 warnings with KDECompilerSettings.
From: "David Faure" <faure () kde ! org>
Date: 2015-12-28 14:23:53
Message-ID: 20151228142353.18086.35826 () mimi ! kde ! org
[Download RAW message or body]
--===============6086414438839898275==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126535/#review90214
-----------------------------------------------------------
Ship it!
Ship It!
- David Faure
On Dec. 27, 2015, 11:45 a.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126535/
> -----------------------------------------------------------
>
> (Updated Dec. 27, 2015, 11:45 a.m.)
>
>
> Review request for Extra Cmake Modules and David Faure.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> We recommend including KDE "settings" modules with NO_POLICY_SCOPE, both
> so we can resolve this issue and to allow us to deal with similar things
> in the future.
>
>
> Diffs
> -----
>
> kde-modules/KDECMakeSettings.cmake c2786c1a8af8b8f36ecd12b919b5ec8856d6724f
> kde-modules/KDECompilerSettings.cmake 73d778255edca3d81ebc2e6b8e67b22896c81fef
> kde-modules/KDEFrameworkCompilerSettings.cmake \
> e88c10d9cc6b5de59912e11de43555f056468cb5
> Diff: https://git.reviewboard.kde.org/r/126535/diff/
>
>
> Testing
> -------
>
> Added NO_POLICY_SCOPE to KArchive's include(KDECompilerSettings), which silenced \
> the CMP0063 warnings.
>
> Thanks,
>
> Alex Merry
>
>
--===============6086414438839898275==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126535/">https://git.reviewboard.kde.org/r/126535/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- David Faure</p>
<br />
<p>On December 27th, 2015, 11:45 a.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Extra Cmake Modules and David Faure.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Dec. 27, 2015, 11:45 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">We recommend including KDE "settings" modules with \
NO_POLICY_SCOPE, both so we can resolve this issue and to allow us to deal with \
similar things in the future.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Added NO_POLICY_SCOPE to KArchive's \
include(KDECompilerSettings), which silenced the CMP0063 warnings.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kde-modules/KDECMakeSettings.cmake <span style="color: \
grey">(c2786c1a8af8b8f36ecd12b919b5ec8856d6724f)</span></li>
<li>kde-modules/KDECompilerSettings.cmake <span style="color: \
grey">(73d778255edca3d81ebc2e6b8e67b22896c81fef)</span></li>
<li>kde-modules/KDEFrameworkCompilerSettings.cmake <span style="color: \
grey">(e88c10d9cc6b5de59912e11de43555f056468cb5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126535/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6086414438839898275==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic