[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-buildsystem
Subject:    Re: Review Request 126368: Include <QDebug> with generated logging category file
From:       "Alex Merry" <alex.merry () kde ! org>
Date:       2015-12-18 22:43:24
Message-ID: 20151218224324.5237.20870 () mimi ! kde ! org
[Download RAW message or body]

--===============4138124709468252121==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126368/#review89727
-----------------------------------------------------------

Ship it!


Ship It!

- Alex Merry


On Dec. 18, 2015, 9:53 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126368/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2015, 9:53 p.m.)
> 
> 
> Review request for Extra Cmake Modules.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> In order to use the logging categories created by ECM,
> the generated header file has to be included but then
> also #include <QDebug> must be added to make it usable
> at all for qCDebug/qCWarning stuff.
> 
> So this puts the #include <QDebug> into the generated
> header file and thus allowing to include a single header
> for qCDebug/qCWarning instead of two.
> 
> 
> Diffs
> -----
> 
> modules/ECMQtDeclareLoggingCategory.cmake b7f1ad3 
> modules/ECMQtDeclareLoggingCategory.h.in fedecd2 
> 
> Diff: https://git.reviewboard.kde.org/r/126368/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
> 


--===============4138124709468252121==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126368/">https://git.reviewboard.kde.org/r/126368/</a>
  </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />









<p>- Alex Merry</p>


<br />
<p>On December 18th, 2015, 9:53 p.m. UTC, Martin Klapetek wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Extra Cmake Modules.</div>
<div>By Martin Klapetek.</div>


<p style="color: grey;"><i>Updated Dec. 18, 2015, 9:53 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">In order to use the logging categories created by ECM, \
the generated header file has to be included but then also #include &lt;QDebug&gt; \
must be added to make it usable at all for qCDebug/qCWarning stuff.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">So this puts the #include &lt;QDebug&gt; into the \
generated header file and thus allowing to include a single header
for qCDebug/qCWarning instead of two.</p></pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>modules/ECMQtDeclareLoggingCategory.cmake <span style="color: \
grey">(b7f1ad3)</span></li>

 <li>modules/ECMQtDeclareLoggingCategory.h.in <span style="color: \
grey">(fedecd2)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126368/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>


--===============4138124709468252121==--


[Attachment #3 (text/plain)]

_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic