[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-buildsystem
Subject: Re: Review Request 126185: Make the KAppTemplate CMake module global
From: "Marco Martin" <notmart () gmail ! com>
Date: 2015-12-18 10:55:18
Message-ID: 20151218105518.5237.50606 () mimi ! kde ! org
[Download RAW message or body]
--===============4922577511309982849==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126185/
-----------------------------------------------------------
(Updated Dec. 18, 2015, 10:55 a.m.)
Review request for Build System, KDE Frameworks, Plasma, Aleix Pol Gonzalez, and \
Simon Wächter.
Changes
-------
now the test generates a package, uncompresses it and checks if it's a correct \
tarball and if some files are indeed in. it passes and tested as well with small \
modifications to make it fail when expected
Repository: extra-cmake-modules
Description
-------
templates are very useful as teaching tool in order to make
a minimal application that uses a certain framework.
templates in the KAppTemplate repository will always get forgotten
(plus kapptemplate is not really necessary as they work in kdevelop as well)
An ideal situation would be frameworks having templates in their own repos
with templates of barebone apps using the main framework features.
In order to do that, the cmake stuff needed in order to correctly install
a template needs to be ported to a place avaiable to all frameworks
Diffs (updated)
-----
kde-modules/KDEInstallDirs.cmake b7cd34d
kde-modules/KDEPackageAppTemplates.cmake PRE-CREATION
tests/CMakeLists.txt 1a66f56
tests/KDEPackageAppTemplatesTest/CMakeLists.txt PRE-CREATION
tests/KDEPackageAppTemplatesTest/check.cmake.in PRE-CREATION
tests/KDEPackageAppTemplatesTest/qml-plasmoid/CMakeLists.txt PRE-CREATION
tests/KDEPackageAppTemplatesTest/qml-plasmoid/Messages.sh PRE-CREATION
tests/KDEPackageAppTemplatesTest/qml-plasmoid/README PRE-CREATION
tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/images/pairs.svgz \
PRE-CREATION tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/ui/main.qml \
PRE-CREATION tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/metadata.desktop \
PRE-CREATION tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.kdevtemplate \
PRE-CREATION tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.png \
PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/126185/diff/
Testing
-------
done some templates installed by plasma-framework
Thanks,
Marco Martin
--===============4922577511309982849==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126185/">https://git.reviewboard.kde.org/r/126185/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Build System, KDE Frameworks, Plasma, Aleix Pol Gonzalez, and \
Simon Wächter.</div> <div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Dec. 18, 2015, 10:55 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">now the test generates a package, uncompresses it and checks if it's \
a correct tarball and if some files are indeed in. it passes and tested as well with \
small modifications to make it fail when expected</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">templates are very useful as teaching tool in order to \
make a minimal application that uses a certain framework.
templates in the KAppTemplate repository will always get forgotten
(plus kapptemplate is not really necessary as they work in kdevelop as well)
An ideal situation would be frameworks having templates in their own repos
with templates of barebone apps using the main framework features.
In order to do that, the cmake stuff needed in order to correctly install
a template needs to be ported to a place avaiable to all frameworks</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">done some templates installed by \
plasma-framework</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kde-modules/KDEInstallDirs.cmake <span style="color: grey">(b7cd34d)</span></li>
<li>kde-modules/KDEPackageAppTemplates.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(1a66f56)</span></li>
<li>tests/KDEPackageAppTemplatesTest/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/KDEPackageAppTemplatesTest/check.cmake.in <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/KDEPackageAppTemplatesTest/qml-plasmoid/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/KDEPackageAppTemplatesTest/qml-plasmoid/Messages.sh <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/KDEPackageAppTemplatesTest/qml-plasmoid/README <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/images/pairs.svgz \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/ui/main.qml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/metadata.desktop <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.kdevtemplate <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.png <span \
style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126185/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4922577511309982849==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic