'Re: Review Request 126303: ECMAddAppIconMacro: Add OUTFILE parameter'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-buildsystem
Subject:    Re: Review Request 126303: ECMAddAppIconMacro: Add OUTFILE parameter
From:       "Alex Merry" <alex.merry () kde ! org>
Date:       2015-12-12 15:42:33
Message-ID: 20151212154233.3920.97085 () mimi ! kde ! org
[Download RAW message or body]

--===============6472462470349088257==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On Dec. 12, 2015, 3:39 p.m., Alex Merry wrote:
> > 

I'm not going to make you write a unit test for this, since this module didn't have \
any to begin with, but if you *were* willing to write tests, I would be very \
grateful.

- Alex

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126303/#review89390
-----------------------------------------------------------

On Dec. 10, 2015, 8:25 p.m., Dominik Schmidt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126303/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2015, 8:25 p.m.)
> 
> 
> Review request for Extra Cmake Modules.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> On OSX I want to ship "Tomahawk.icns" instead of "tomahawkSources.icns" which is \
> the autogenerated name for our sources variable, thus I added an optional paramater \
> allowing to override the basename (without extension). 
> 
> Diffs
> -----
> 
> modules/ECMAddAppIcon.cmake f90d4c3 
> 
> Diff: https://git.reviewboard.kde.org/r/126303/diff/
> 
> 
> Testing
> -------
> 
> Tested it in Tomahawk and it works.
> 
> edit1: Actually, something is fishy. Still investigating.
> edit2: Nope, everything's fine. Random CMake fnord, hadn't tried a clean build.
> 
> 
> Thanks,
> 
> Dominik Schmidt
> 
> 

--===============6472462470349088257==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126303/">https://git.reviewboard.kde.org/r/126303/</a>
  </td>
    </tr>
   </table>
   <br />

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm \
not going to make you write a unit test for this, since this module didn't have any \
to begin with, but if you <em style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">were</em> willing to write tests, I \
would be very grateful.</p></pre> <br />

<p>- Alex</p>

<br />
<p>On December 10th, 2015, 8:25 p.m. UTC, Dominik Schmidt wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Extra Cmake Modules.</div>
<div>By Dominik Schmidt.</div>

<p style="color: grey;"><i>Updated Dec. 10, 2015, 8:25 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On OSX I want to ship "Tomahawk.icns" instead of \
"tomahawkSources.icns" which is the autogenerated name for our sources variable, thus \
I added an optional paramater allowing to override the basename (without \
extension).</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested it in Tomahawk and it works.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
                inherit;">edit1: Actually, something is fishy. Still investigating.
edit2: Nope, everything's fine. Random CMake fnord, hadn't tried a clean \
build.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>modules/ECMAddAppIcon.cmake <span style="color: grey">(f90d4c3)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126303/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6472462470349088257==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

[prev in list] [next in list] [prev in thread] [next in thread] 