[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 126230: Make python, gettext and Qt5::QML optional for ki18n
From: "Alex Merry" <alex.merry () kde ! org>
Date: 2015-12-09 10:35:17
Message-ID: 20151209103517.30410.4264 () mimi ! kde ! org
[Download RAW message or body]
--===============9096412076919571627==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126230/#review89271
-----------------------------------------------------------
cmake/KF5I18NMacros.cmake (lines 55 - 58)
<https://git.reviewboard.kde.org/r/126230/#comment61053>
If a project uses ki18n_install_ts_files, it will still fail with this change. It \
just won't be at all obvious to the user *why* it failed: they will get a message \
about an unknown command, which they may or may not realise is linked to an earlier \
vague message about Python and Gettext being needed.
If you're going to take this approach, I think you still need to define \
k18n_install_ts_files in the else() branch, but make it spit out an error about \
exactly what package(s) are missing.
- Alex Merry
On Dec. 4, 2015, 12:17 a.m., Boudewijn Rempt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126230/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2015, 12:17 a.m.)
>
>
> Review request for Build System, KDE Frameworks, Aleix Pol Gonzalez, Chusslove \
> Illich, and Luigi Toscano.
>
> Repository: ki18n
>
>
> Description
> -------
>
> When building ki18n as a dependency framework for shipping with an application, the \
> tools to actually create and manage translations are superfluous. These tools have \
> some big dependencies that are a pain to have around, especially gettext on \
> Windows. This patch makes the requirement for Python and Gettext optional.
> This patch checks the BUILD_TESTING variable to see if the autotests should be \
> built, because when we just need the library to build an application we shouldn't \
> waste electicity building the tests (and the Qt5::QML dependency).
>
> Diffs
> -----
>
> CMakeLists.txt 59917fa
> cmake/KF5I18NMacros.cmake 53ba812
>
> Diff: https://git.reviewboard.kde.org/r/126230/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Boudewijn Rempt
>
>
--===============9096412076919571627==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126230/">https://git.reviewboard.kde.org/r/126230/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/126230/diff/3/?file=420893#file420893line61" \
style="color: black; font-weight: bold; text-decoration: \
underline;">cmake/KF5I18NMacros.cmake</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">55</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">find_package</span><span class="p">(</span><span \
class="s">Gettext</span><span class="p">)</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">56</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">find_package</span><span class="p">(</span><span \
class="s">PythonInterp</span><span class="p">)</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">57</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">58</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">if</span> <span class="p">(</span><span class="s">Gettext_FOUND</span> \
<span class="s">AND</span> <span class="s">PythonInterp_FOUND</span><span \
class="p">)</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If a \
project uses ki18n_install_ts_files, it will still fail with this change. It just \
won't be at all obvious to the user <em style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">why</em> it failed: they \
will get a message about an unknown command, which they may or may not realise is \
linked to an earlier vague message about Python and Gettext being needed.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">If you're going to take this approach, I think you still need to define \
k18n_install_ts_files in the else() branch, but make it spit out an error about \
exactly what package(s) are missing.</p></pre> </div>
</div>
<br />
<p>- Alex Merry</p>
<br />
<p>On December 4th, 2015, 12:17 a.m. UTC, Boudewijn Rempt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Build System, KDE Frameworks, Aleix Pol Gonzalez, Chusslove \
Illich, and Luigi Toscano.</div> <div>By Boudewijn Rempt.</div>
<p style="color: grey;"><i>Updated Dec. 4, 2015, 12:17 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ki18n
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When building ki18n as a dependency framework for \
shipping with an application, the tools to actually create and manage translations \
are superfluous. These tools have some big dependencies that are a pain to have \
around, especially gettext on Windows. This patch makes the requirement for Python \
and Gettext optional.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">This patch checks the BUILD_TESTING \
variable to see if the autotests should be built, because when we just need the \
library to build an application we shouldn't waste electicity building the tests (and \
the Qt5::QML dependency).</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(59917fa)</span></li>
<li>cmake/KF5I18NMacros.cmake <span style="color: grey">(53ba812)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126230/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============9096412076919571627==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic