[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-buildsystem
Subject: Re: Review Request 126000: Make sure we load translations on the main thread.
From: "Alex Merry" <alex.merry () kde ! org>
Date: 2015-11-30 14:07:51
Message-ID: 20151130140751.29696.90861 () mimi ! kde ! org
[Download RAW message or body]
--===============5079589090129059249==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126000/
-----------------------------------------------------------
(Updated Nov. 30, 2015, 2:07 p.m.)
Status
------
This change has been marked as submitted.
Review request for Extra Cmake Modules and David Faure.
Changes
-------
Submitted with commit fb4d91996affdbcd3ffc19c7646fbf77b96bf1e5 by Alex Merry to \
branch master.
Bugs: 346188
http://bugs.kde.org/show_bug.cgi?id=346188
Repository: extra-cmake-modules
Description
-------
Because the old implementation (accidentally) worked when you put the
ecm_create_qm_loader call in a different CMakeLists.txt file to the
target the file was added to, some projects did this.
This won't work with build-time-generated files, though, like moc files.
So we (ab)use QTimer events to make the loading happen on the main
thread.
BUG: 346188
Diffs
-----
modules/ECMPoQmTools.cmake 0af5b12fdd662c07792e6084b7279b98dc99cf97
modules/ECMQmLoader.cpp.in 423d1c932ddcf3d98c94d2f67e73355129357768
tests/ECMPoQmToolsTest/CMakeLists.txt 73d2b4271d646107ce02bb2da71fbe0d11f80fc8
tests/ECMPoQmToolsTest/check.cmake.in 5329b78d06bebb9aa14595201f45ac868afd8e81
tests/ECMPoQmToolsTest/check_conf.cmake.in 7bd11c36e2830e868c83f455e4b2809b72fcb3ce \
tests/ECMPoQmToolsTest/tr_thread_test.cpp PRE-CREATION
tests/ECMPoQmToolsTest/tr_thread_test_module.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/126000/diff/
Testing
-------
Extended unit tests, which pass. Built the world (all the default frameworks stuff) \
with kdesrc-build.
Thanks,
Alex Merry
--===============5079589090129059249==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126000/">https://git.reviewboard.kde.org/r/126000/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Extra Cmake Modules and David Faure.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Nov. 30, 2015, 2:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit fb4d91996affdbcd3ffc19c7646fbf77b96bf1e5 by Alex \
Merry to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=346188">346188</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Because the old implementation (accidentally) worked \
when you put the ecm_create_qm_loader call in a different CMakeLists.txt file to the
target the file was added to, some projects did this.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This won't work with build-time-generated files, \
though, like moc files. So we (ab)use QTimer events to make the loading happen on the \
main thread.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">BUG: 346188</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Extended unit tests, which pass. Built the world (all \
the default frameworks stuff) with kdesrc-build.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>modules/ECMPoQmTools.cmake <span style="color: \
grey">(0af5b12fdd662c07792e6084b7279b98dc99cf97)</span></li>
<li>modules/ECMQmLoader.cpp.in <span style="color: \
grey">(423d1c932ddcf3d98c94d2f67e73355129357768)</span></li>
<li>tests/ECMPoQmToolsTest/CMakeLists.txt <span style="color: \
grey">(73d2b4271d646107ce02bb2da71fbe0d11f80fc8)</span></li>
<li>tests/ECMPoQmToolsTest/check.cmake.in <span style="color: \
grey">(5329b78d06bebb9aa14595201f45ac868afd8e81)</span></li>
<li>tests/ECMPoQmToolsTest/check_conf.cmake.in <span style="color: \
grey">(7bd11c36e2830e868c83f455e4b2809b72fcb3ce)</span></li>
<li>tests/ECMPoQmToolsTest/tr_thread_test.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/ECMPoQmToolsTest/tr_thread_test_module.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126000/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5079589090129059249==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic