[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 125236: FindQt4: Use CHECK_CXX_SYMBOL_EXISTS instead of CHECK_C_SYMBOL_EXISTS.
From: "Raphael Kubo da Costa" <rakuco () FreeBSD ! org>
Date: 2015-11-29 18:15:44
Message-ID: 20151129181544.29696.19638 () mimi ! kde ! org
[Download RAW message or body]
--===============7431543753499879297==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125236/
-----------------------------------------------------------
(Updated Nov. 29, 2015, 8:15 p.m.)
Status
------
This change has been discarded.
Review request for Build System and kdelibs.
Repository: kdelibs
Description
-------
Backport upstream CMake commit de30173d ("Remove C compiler requirement
from FindQt4.cmake") from 2011 so that we check for symbols such as the
Q_WS_* ones with a C++ compiler instead of a C one.
Diffs
-----
cmake/modules/FindQt4.cmake e439a72f82c51758830b057b368407e11a6a541e
Diff: https://git.reviewboard.kde.org/r/125236/diff/
Testing
-------
Adding something C++-specific to qglobal.h (e.g. `#include <ciso646>`)
works and the right flags are still detected.
Thanks,
Raphael Kubo da Costa
--===============7431543753499879297==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125236/">https://git.reviewboard.kde.org/r/125236/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Build System and kdelibs.</div>
<div>By Raphael Kubo da Costa.</div>
<p style="color: grey;"><i>Updated Nov. 29, 2015, 8:15 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Backport upstream CMake commit de30173d ("Remove C compiler \
requirement from FindQt4.cmake") from 2011 so that we check for symbols such as \
the Q_WS_* ones with a C++ compiler instead of a C one.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Adding something C++-specific to qglobal.h (e.g. <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">#include <ciso646></code>) works and the right flags \
are still detected.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/FindQt4.cmake <span style="color: \
grey">(e439a72f82c51758830b057b368407e11a6a541e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125236/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7431543753499879297==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic