[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-buildsystem
Subject: Re: Review Request 126183: Add a FindPoppler module to ECM
From: "Alex Merry" <alex.merry () kde ! org>
Date: 2015-11-28 18:19:04
Message-ID: 20151128181904.23104.31992 () mimi ! kde ! org
[Download RAW message or body]
--===============8221921454113652462==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126183/#review88914
-----------------------------------------------------------
Ship it!
I'm happy for this to go in, if the Okular and KBibTex projects are happy to use it.
- Alex Merry
On Nov. 28, 2015, 12:43 p.m., Alex Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126183/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2015, 12:43 p.m.)
>
>
> Review request for Extra Cmake Modules, Albert Astals Cid and Tobias Koenig.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> At least Okular and KBibTex include a FindPoppler.cmake module but this one
> uses the new ECMFindModuleHelpers and has imported targets.
>
> ---
>
> To make FindPoppler.cmake work without pkg-config it also includes this commit:
>
>
> Use PATH_SUFFIXES in ecm_find_package_handle_library_components()
>
>
> This is required to find poppler without package config as all the headers
> are installed in a poppler subdirectory of the include directory
>
>
> Diffs
> -----
>
> find-modules/FindPoppler.cmake PRE-CREATION
> find-modules/FindWayland.cmake c5a56c1635d03acdaf5ccd780b9a358d6f6655fd
> modules/ECMFindModuleHelpers.cmake 2044efe1ccf679b738f68aec9b3fb007c449717c
>
> Diff: https://git.reviewboard.kde.org/r/126183/diff/
>
>
> Testing
> -------
>
> Okular can be built using this find module with minor changes. As it doesn't set \
> various HAVE_POPPLER_0_36 etc. variables that the find module in okular did, I set \
> those variables in the okular CMakeLists.txt
>
> Thanks,
>
> Alex Richardson
>
>
--===============8221921454113652462==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126183/">https://git.reviewboard.kde.org/r/126183/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm \
happy for this to go in, if the Okular and KBibTex projects are happy to use \
it.</p></pre> <br />
<p>- Alex Merry</p>
<br />
<p>On November 28th, 2015, 12:43 p.m. UTC, Alex Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Extra Cmake Modules, Albert Astals Cid and Tobias \
Koenig.</div> <div>By Alex Richardson.</div>
<p style="color: grey;"><i>Updated Nov. 28, 2015, 12:43 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">At least Okular and KBibTex include a \
FindPoppler.cmake module but this one uses the new ECMFindModuleHelpers and has \
imported targets.</p> <hr style="text-rendering: inherit;margin: 0;padding: \
0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" /> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">To make FindPoppler.cmake work without pkg-config it also includes this \
commit:</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Use PATH_SUFFIXES in \
ecm_find_package_handle_library_components()</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This is required to \
find poppler without package config as all the headers are installed in a poppler \
subdirectory of the include directory</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Okular can be built using this find module with minor \
changes. As it doesn't set various HAVE_POPPLER_0_36 etc. variables that the find \
module in okular did, I set those variables in the okular CMakeLists.txt</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>find-modules/FindPoppler.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>find-modules/FindWayland.cmake <span style="color: \
grey">(c5a56c1635d03acdaf5ccd780b9a358d6f6655fd)</span></li>
<li>modules/ECMFindModuleHelpers.cmake <span style="color: \
grey">(2044efe1ccf679b738f68aec9b3fb007c449717c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126183/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8221921454113652462==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic