[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-buildsystem
Subject: Re: Review Request 126075: Overhaul the ECM build system.
From: "Alex Merry" <alex.merry () kde ! org>
Date: 2015-11-22 10:40:33
Message-ID: 20151122104033.14400.93701 () mimi ! kde ! org
[Download RAW message or body]
--===============5324118589833513574==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126075/
-----------------------------------------------------------
(Updated Nov. 22, 2015, 10:40 a.m.)
Status
------
This change has been marked as submitted.
Review request for Extra Cmake Modules and David Faure.
Changes
-------
Submitted with commit c941061aa989bba945e296aad47df22f9c8ddd5f by Alex Merry to \
branch master.
Repository: extra-cmake-modules
Description
-------
It should now be easier to read, and more featureful. Among other
tweaks, we now print a summary of dependencies and build options, and
the documentation is generated with more sensible breadcrumbs and
builds properly with Sphinx 1.3.
Diffs
-----
.gitignore PRE-CREATION
CMakeLists.txt c1abd6c7be925dcebd5e9962fa05ae143abdf76b
ECMConfig.cmake.in b163e3ae6e7b0f0f4d4620700a35ac501c6f94f8
cmake/FindQCollectionGenerator.cmake PRE-CREATION
cmake/FindSphinx.cmake PRE-CREATION
docs/CMakeLists.txt f17400f8e96886c8beba45b9c9322960be20ba43
docs/sphinx/conf.py.in 792c87ca1386ef3f7d8d58d6546c81c11d920e2f
docs/sphinx/ecm.py
docs/sphinx/static/ecm.css 2a326d47dda1d74f20aa6d7a65e27ffae26f08c3
tests/CMakeLists.txt 9e6de12f2b82766aa0ab592fb4dff61f09b289e1
tests/ECMGenerateHeadersTest/CMakeLists.txt \
9f407cb09064b9a278a74e183a7c2136337729fc \
tests/ECMGeneratePkgConfigFile/CMakeLists.txt \
f3bc267d9ed14881807deebaf8fd11fe6ae6402d
Diff: https://git.reviewboard.kde.org/r/126075/diff/
Testing
-------
Configured, built and installed with CMake 2.8.12.2 and with CMake 3.3.
Tested with various combinations of sphinx-build 1.3.1 (python2 and python3 versions) \
and qcollectiongenerator (Qt4 and Qt5 versions) installed or not.
All seem to work sensibly.
Generated HTML documentation checked by eye.
sphinx-build 1.2.2 (used by api.kde.org) *not* tested.
Example output:
-- Found Sphinx: /usr/bin/sphinx-build (found suitable version "1.3.1", minimum \
required is "1.2")
-- Found QCollectionGenerator: /usr/bin/qcollectiongenerator (found version \
"1.0")
-- The C compiler identification is GNU 5.2.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
--
-- The following features have been enabled:
* BUILD_HTML_DOCS , Generate HTML documentation for installed modules.
* BUILD_MAN_DOCS , Generate man page documentation for installed modules.
* BUILD_QTHELP_DOCS , Generate QtHelp documentation for installed modules.
* BUILD_TESTING , Build automated tests.
-- The following OPTIONAL packages have been found:
* Sphinx (required version >= 1.2) , Tool to generate documentation. , \
<http://sphinx-doc.org/> Required to build documentation for Extra CMake Modules.
* QCollectionGenerator , Qt help collection generator. , <http://www.qt.io/>
Required to build Extra CMake Modules documentation in Qt Help format.
* Qt5LinguistTools , Qt5 linguist tools. , <http://www.qt.io/>
Required to run tests for the ECMPoQmTools module.
* Qt5Core , Qt5 core library. , <http://www.qt.io/>
Required to run tests for the ECMQtDeclareLoggingCategory module, and for some \
tests of the KDEInstallDirs module.
-- Configuring done
-- Generating done
-- Build files have been written to: \
/home/kde-devel/src/extra-cmake-modules/build
Thanks,
Alex Merry
--===============5324118589833513574==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126075/">https://git.reviewboard.kde.org/r/126075/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Extra Cmake Modules and David Faure.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Nov. 22, 2015, 10:40 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit c941061aa989bba945e296aad47df22f9c8ddd5f by Alex \
Merry to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It should now be easier to read, and more featureful. Among other \
tweaks, we now print a summary of dependencies and build options, and the \
documentation is generated with more sensible breadcrumbs and builds properly with \
Sphinx 1.3.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Configured, built and installed with CMake 2.8.12.2 \
and with CMake 3.3.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Tested with various combinations of \
sphinx-build 1.3.1 (python2 and python3 versions) and qcollectiongenerator (Qt4 and \
Qt5 versions) installed or not.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">All seem to work \
sensibly.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Generated HTML documentation checked by eye.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">sphinx-build 1.2.2 (used by api.kde.org) <em style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">not</em> tested.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Example output:</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div \
class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">-- \
Found Sphinx: /usr/bin/sphinx-build (found suitable version "1.3.1", \
minimum required is "1.2")
-- Found QCollectionGenerator: /usr/bin/qcollectiongenerator (found version \
"1.0")
-- The C compiler identification is GNU 5.2.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
--
-- The following features have been enabled:
* BUILD_HTML_DOCS , Generate HTML documentation for installed modules.
* BUILD_MAN_DOCS , Generate man page documentation for installed modules.
* BUILD_QTHELP_DOCS , Generate QtHelp documentation for installed modules.
* BUILD_TESTING , Build automated tests.
-- The following OPTIONAL packages have been found:
* Sphinx (required version >= 1.2) , Tool to generate documentation. , \
<http://sphinx-doc.org/> Required to build documentation for Extra CMake \
Modules.
* QCollectionGenerator , Qt help collection generator. , <http://www.qt.io/>
Required to build Extra CMake Modules documentation in Qt Help format.
* Qt5LinguistTools , Qt5 linguist tools. , <http://www.qt.io/>
Required to run tests for the ECMPoQmTools module.
* Qt5Core , Qt5 core library. , <http://www.qt.io/>
Required to run tests for the ECMQtDeclareLoggingCategory module, and for some \
tests of the KDEInstallDirs module.
-- Configuring done
-- Generating done
-- Build files have been written to: /home/kde-devel/src/extra-cmake-modules/build
</pre></div>
</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>.gitignore <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: \
grey">(c1abd6c7be925dcebd5e9962fa05ae143abdf76b)</span></li>
<li>ECMConfig.cmake.in <span style="color: \
grey">(b163e3ae6e7b0f0f4d4620700a35ac501c6f94f8)</span></li>
<li>cmake/FindQCollectionGenerator.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>cmake/FindSphinx.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>docs/CMakeLists.txt <span style="color: \
grey">(f17400f8e96886c8beba45b9c9322960be20ba43)</span></li>
<li>docs/sphinx/conf.py.in <span style="color: \
grey">(792c87ca1386ef3f7d8d58d6546c81c11d920e2f)</span></li>
<li>docs/sphinx/ecm.py <span style="color: grey">()</span></li>
<li>docs/sphinx/static/ecm.css <span style="color: \
grey">(2a326d47dda1d74f20aa6d7a65e27ffae26f08c3)</span></li>
<li>tests/CMakeLists.txt <span style="color: \
grey">(9e6de12f2b82766aa0ab592fb4dff61f09b289e1)</span></li>
<li>tests/ECMGenerateHeadersTest/CMakeLists.txt <span style="color: \
grey">(9f407cb09064b9a278a74e183a7c2136337729fc)</span></li>
<li>tests/ECMGeneratePkgConfigFile/CMakeLists.txt <span style="color: \
grey">(f3bc267d9ed14881807deebaf8fd11fe6ae6402d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126075/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5324118589833513574==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic