'Re: Review Request 125935: Do not find XCB's XINPUT library by default.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-buildsystem
Subject:    Re: Review Request 125935: Do not find XCB's XINPUT library by default.
From:       "Alex Merry" <alex.merry () kde ! org>
Date:       2015-11-17 21:23:38
Message-ID: 20151117212338.14400.34152 () mimi ! kde ! org
[Download RAW message or body]

--===============3456338761397994223==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125935/
-----------------------------------------------------------

(Updated Nov. 17, 2015, 9:23 p.m.)

Status
------

This change has been marked as submitted.

Review request for Extra Cmake Modules and Martin Gräßlin.

Changes
-------

Submitted with commit 7d6915b482820e53c46b3a68ac27d2ef8485a248 by Alex Merry to \
branch master.

Repository: extra-cmake-modules

Description
-------

The XINPUT library is unlikely to be available on many systems,
including a lot of Linux distributions. This will warn developers in
advance by (a) not searching for XINPUT unless it was explicitly
requested, and (b) printing a warning if they do request it.

Diffs
-----

  find-modules/FindXCB.cmake b2a800f73058382ee84f7d93132a96f8852b4aa7 
  modules/ECMFindModuleHelpers.cmake 63cccb933334e0c392159abe161419d3f48b21f3 

Diff: https://git.reviewboard.kde.org/r/125935/diff/

Testing
-------

wacomtablet's kf5-port branch still configures, but with a warning. kwin configures \
without a warning. Modified kwindowsystem to call find_package(XCB), and that also \
configures without a warning.

Thanks,

Alex Merry

--===============3456338761397994223==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125935/">https://git.reviewboard.kde.org/r/125935/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Extra Cmake Modules and Martin Gräßlin.</div>
<div>By Alex Merry.</div>

<p style="color: grey;"><i>Updated Nov. 17, 2015, 9:23 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 7d6915b482820e53c46b3a68ac27d2ef8485a248 by Alex \
Merry to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The XINPUT library is unlikely to be available on many systems, \
including a lot of Linux distributions. This will warn developers in advance by (a) \
not searching for XINPUT unless it was explicitly requested, and (b) printing a \
warning if they do request it.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">wacomtablet's kf5-port branch still configures, but \
with a warning. kwin configures without a warning. Modified kwindowsystem to call \
find_package(XCB), and that also configures without a warning.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>find-modules/FindXCB.cmake <span style="color: \
grey">(b2a800f73058382ee84f7d93132a96f8852b4aa7)</span></li>

 <li>modules/ECMFindModuleHelpers.cmake <span style="color: \
grey">(63cccb933334e0c392159abe161419d3f48b21f3)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125935/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3456338761397994223==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

[prev in list] [next in list] [prev in thread] [next in thread] 