[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-buildsystem
Subject: Re: Review Request 125931: Warn instead of error if ecm_install_icons finds no icons.
From: "Alex Merry" <alex.merry () kde ! org>
Date: 2015-11-04 9:41:01
Message-ID: 20151104094101.24343.73596 () mimi ! kde ! org
[Download RAW message or body]
--===============2390275200409521752==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125931/
-----------------------------------------------------------
(Updated Nov. 4, 2015, 9:41 a.m.)
Status
------
This change has been marked as submitted.
Review request for Extra Cmake Modules.
Changes
-------
Submitted with commit 21629f651a6a5d9d977be03fd9f98417c4fa27ae by Alex Merry to \
branch master.
Repository: extra-cmake-modules
Description
-------
The V1 syntax of ecm_install_icons searched for icons by globbing files
with a particular naming pattern. If there were no such icons, this used
to do nothing, but silently. Commit fb7b8eea7d accidentally made this an
error. More sensible would be to make it a warning.
BUG: 354610
Diffs
-----
modules/ECMInstallIcons.cmake 8db486e7ab0db3d9f43d09a4b8b22a97a07b3bae
tests/ECMInstallIconsTest/CMakeLists.txt 738cba916a2798d5ef63300f0db418e2ee9fb3be
tests/ECMInstallIconsTest/v1-syntax-no-icons/CMakeLists.txt PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/125931/diff/
Testing
-------
Extended unit test, which passes, and ksirk now successfully configures.
Thanks,
Alex Merry
--===============2390275200409521752==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125931/">https://git.reviewboard.kde.org/r/125931/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Extra Cmake Modules.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Nov. 4, 2015, 9:41 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 21629f651a6a5d9d977be03fd9f98417c4fa27ae by Alex \
Merry to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The V1 syntax of ecm_install_icons searched for icons by globbing files \
with a particular naming pattern. If there were no such icons, this used to do \
nothing, but silently. Commit fb7b8eea7d accidentally made this an error. More \
sensible would be to make it a warning.
BUG: 354610</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Extended unit test, which passes, and ksirk now \
successfully configures.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>modules/ECMInstallIcons.cmake <span style="color: \
grey">(8db486e7ab0db3d9f43d09a4b8b22a97a07b3bae)</span></li>
<li>tests/ECMInstallIconsTest/CMakeLists.txt <span style="color: \
grey">(738cba916a2798d5ef63300f0db418e2ee9fb3be)</span></li>
<li>tests/ECMInstallIconsTest/v1-syntax-no-icons/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125931/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2390275200409521752==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic