[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 125560: Give unique names to the targets created by KDE4Macros.cmake
From: "Luigi Toscano" <luigi.toscano () tiscali ! it>
Date: 2015-10-08 19:56:44
Message-ID: 20151008195644.17685.87998 () mimi ! kde ! org
[Download RAW message or body]
--===============6866746940751113190==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125560/#review86521
-----------------------------------------------------------
This is the backport of the same fix applied long time ago to KDocTools, so \
generating longer, unique target names. The change is basically the same and it has \
been throughly tested. I would wait few days and if no one else object, I would give \
a ship it.
- Luigi Toscano
On Ott. 8, 2015, 7:38 p.m., Hrvoje Senjan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125560/
> -----------------------------------------------------------
>
> (Updated Ott. 8, 2015, 7:38 p.m.)
>
>
> Review request for Build System, kdelibs and Luigi Toscano.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Backport of review 116650.
> Needed to fix build of some software after kdelibs' 4.14.11 cmake refactoring
>
>
> Diffs
> -----
>
> cmake/modules/KDE4Macros.cmake 8622959
>
> Diff: https://git.reviewboard.kde.org/r/125560/diff/
>
>
> Testing
> -------
>
> k3b and skanlite tarballs now build.
>
>
> Thanks,
>
> Hrvoje Senjan
>
>
--===============6866746940751113190==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125560/">https://git.reviewboard.kde.org/r/125560/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
is the backport of the same fix applied long time ago to KDocTools, so generating \
longer, unique target names. The change is basically the same and it has been \
throughly tested. I would wait few days and if no one else object, I would give a \
ship it.</p></pre> <br />
<p>- Luigi Toscano</p>
<br />
<p>On ottobre 8th, 2015, 7:38 p.m. CEST, Hrvoje Senjan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Build System, kdelibs and Luigi Toscano.</div>
<div>By Hrvoje Senjan.</div>
<p style="color: grey;"><i>Updated Ott. 8, 2015, 7:38 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Backport of review 116650. Needed to fix build of some \
software after kdelibs' 4.14.11 cmake refactoring</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">k3b and skanlite tarballs now build.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/KDE4Macros.cmake <span style="color: grey">(8622959)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125560/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6866746940751113190==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic