'Re: Review Request 125163: Disable X11,XCB etc. detection on OS X'

[prev in list] [next in list] [prev in thread] [next in thread] 

List: kde-buildsystem
Subject: Re: Review Request 125163: Disable X11,XCB etc. detection on OS X
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2015-09-14 6:11:44
Message-ID: 20150914061144.3546.37527 () mimi ! kde ! org
[Download RAW message or body]

--===============2170089893289768330==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

> On Sept. 13, 2015, 11:52 a.m., Martin Gräßlin wrote:
> > I'm in favor of the approach as this solves the problem that again and again [1] \
> > we have attempts of OSX-specific disabling of X11 in various frameworks and \
> > applications. 
> > The big problem on OSX seems to be that one doesn't want suport for X11, as it's \
> > not the windowing system. The code we have in our frameworks which is X11 \
> > specific performs runtime checks, thus is dead code on OSX anyway. For (to me \
> > unknown) reasons X11 gets pulled in during build on OSX though, causing either \
> > useless or crashy code to be included. Thus there are attempts to patch the \
> > frameworks instead of just fixing the cmake build command. 
> > I understand that it's a behavior change and thus dangerous. But that's the same \
> > for each framework which gets "fixed" in the way I describe above. In the end \
> > from what I understood from our OSX devs: they don't want X11 and it's from their \
> > perspective a bug that it gets picked up. To me it sounds like we should really \
> > break our rules to provide an overall better product. Thousand micro-edits in the \
> > frameworks are more dangerous than the one time explicit break. 
> > For what is worth I suggest that a warning could be printed by CMake, that those \
> > modules are not searched for and what's the command to override it. 
> > [1] There is already a huge list of reviews which I blocked because they were \
> > just wrong, but there are probably way more frameworks which got "fixed" where I \
> > just didn't notice the review.
> 
> Samuel Gaist wrote:
> Getting X11 in the process is pretty easy: install ffmpeg with macports and you \
> have it in (or at least parts of it). 
> One problem I see about X11 on OS X is that it's not an official or tested platform \
> for Qt and like you said most of the code already disables it at run time in KDE. I \
> don't know the effort (in man power) needed to support it properly. I think that \
> would mean at least having a CI building Qt 5 and running tests for that combo to \
> ensure everything is running fine from a Qt point of view. 
> @martin, can you share that list ? It could help speed things up to build a full \
> KDE on OS X 
> Allen Winter wrote:
> right. I wouldn't object to going even further than this patch: Don't check for X11 \
> on MAC. make sure FOUND_X11 is always FALSE. Just like you wouldn't check for X11 \
> on Windows.

> @martin, can you share that list ? It could help speed things up to build a full \
> KDE on OS X

sorry, I don't track them and wouldn't know how to find it quickly. In the end I \
don't think it matters to know those. Specify no X11 and all is fine.

- Martin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125163/#review85307
-----------------------------------------------------------

On Sept. 12, 2015, 11:19 p.m., Samuel Gaist wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125163/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2015, 11:19 p.m.)
> 
> 
> Review request for Extra Cmake Modules.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Disable X11,XCB etc. detection on OS X
> 
> 
> Diffs
> -----
> 
> kde-modules/KDECMakeSettings.cmake 0c997931abee8673ccecc66d122108c6f72bf9b1 
> 
> Diff: https://git.reviewboard.kde.org/r/125163/diff/
> 
> 
> Testing
> -------
> 
> KCrash build on OS X 10.8
> 
> 
> Thanks,
> 
> Samuel Gaist
> 
> 

--===============2170089893289768330==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125163/">https://git.reviewboard.kde.org/r/125163/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> On September 13th, 2015, 11:52 a.m. CEST, \
Martin Gräßlin wrote: <blockquote style="margin-left: 1em; border-left: \
2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; \
white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; \
word-wrap: break-word;">I'm in favor of the approach as this \
solves the problem that again and again [1] we have attempts of OSX-specific \
disabling of X11 in various frameworks and applications. The \
big problem on OSX seems to be that one doesn't want suport for X11, as it's not the \
windowing system. The code we have in our frameworks which is X11 specific performs \
runtime checks, thus is dead code on OSX anyway. For (to me unknown) reasons X11 gets \
pulled in during build on OSX though, causing either useless or crashy code to be \
included. Thus there are attempts to patch the frameworks instead of just fixing the \
cmake build command. I understand that it's a behavior \
change and thus dangerous. But that's the same for each framework which gets "fixed" \
in the way I describe above. In the end from what I understood from our OSX devs: \
they don't want X11 and it's from their perspective a bug that it gets picked up. To \
me it sounds like we should really break our rules to provide an overall better \
product. Thousand micro-edits in the frameworks are more dangerous than the one time \
explicit break. For what is worth I suggest that a \
warning could be printed by CMake, that those modules are not searched for and what's \
the command to override it. [1] There is already a huge list of \
reviews which I blocked because they were just wrong, but there are probably way more \
frameworks which got "fixed" where I just didn't notice the review.</pre> \
</blockquote>

 <p>On September 13th, 2015, 7:08 p.m. CEST, <b>Samuel Gaist</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Getting X11 in the process is pretty easy: install ffmpeg with macports and \
you have it in (or at least parts of it).</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">One problem I see about \
X11 on OS X is that it's not an official or tested platform for Qt and like you said \
most of the code already disables it at run time in KDE. I don't know the effort (in \
man power) needed to support it properly. I think that would mean at least having a \
CI building Qt 5 and running tests for that combo to ensure everything is running \
fine from a Qt point of view.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">@martin, can you share \
that list ? It could help speed things up to build a full KDE on OS X</p></pre>  \
</blockquote>

 <p>On September 13th, 2015, 10:12 p.m. CEST, <b>Allen Winter</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">right. I wouldn't object to going even further than this patch: Don't check \
for X11 on MAC. make sure FOUND_X11 is always FALSE. Just like you wouldn't check for \
X11 on Windows.</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote \
style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">@martin, can you share that list ? It could help speed things up to build a \
full KDE on OS X</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">sorry, I don't track them and wouldn't know how to \
find it quickly. In the end I don't think it matters to know those. Specify no X11 \
and all is fine.</p></pre> <br />

<p>- Martin</p>

<br />
<p>On September 12th, 2015, 11:19 p.m. CEST, Samuel Gaist wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Extra Cmake Modules.</div>
<div>By Samuel Gaist.</div>

<p style="color: grey;"><i>Updated Sept. 12, 2015, 11:19 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Disable X11,XCB etc. detection on OS X</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">KCrash build on OS X 10.8</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kde-modules/KDECMakeSettings.cmake <span style="color: \
grey">(0c997931abee8673ccecc66d122108c6f72bf9b1)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125163/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2170089893289768330==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

[prev in list] [next in list] [prev in thread] [next in thread] 