[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-buildsystem
Subject: Re: Review Request 125163: Disable X11,XCB etc. detection on OS X
From: "Alex Merry" <alex.merry () kde ! org>
Date: 2015-09-12 21:11:12
Message-ID: 20150912211112.24667.72964 () mimi ! kde ! org
[Download RAW message or body]
--===============6782790068785568749==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Sept. 12, 2015, 11:08 a.m., Alex Merry wrote:
> > The new option needs documenting at the top of the file.
> >
> > I'd like to have other Mac users / porters providing some input, if possible. In \
> > what circumstances would it be useful to use the new option? Is this going to \
> > affect homebrew or macports (ie: do they provide packages that they will have to \
> > set this option for, and is someone planning to inform them of this)?
>
> Samuel Gaist wrote:
> The idea I had behind that option was to let the users/porters decide whether or \
> not they want to build against X11 on OS X. It might not make sense at first but \
> since macports at least provides Xorg.
> I didn't tought about informing them about it but I will gladly do it if the option \
> stays.
> Note that I'm not against removing it at all, it really is just to simplify life of \
> people who would need to build against X11 on OS X.
It's not the option I'm concerned about as such, it's the fact that this patch \
changes the default behaviour. So anyone wanting to build against X11 on OS X would \
now have to set this option, whereas before they just had to have Xorg installed and \
findable by CMake.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125163/#review85248
-----------------------------------------------------------
On Sept. 12, 2015, 8:44 p.m., Samuel Gaist wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125163/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2015, 8:44 p.m.)
>
>
> Review request for Extra Cmake Modules.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> Disable X11,XCB etc. detection on OS X
>
>
> Diffs
> -----
>
> kde-modules/KDECMakeSettings.cmake 0c997931abee8673ccecc66d122108c6f72bf9b1
>
> Diff: https://git.reviewboard.kde.org/r/125163/diff/
>
>
> Testing
> -------
>
> KCrash build on OS X 10.8
>
>
> Thanks,
>
> Samuel Gaist
>
>
--===============6782790068785568749==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125163/">https://git.reviewboard.kde.org/r/125163/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 12th, 2015, 11:08 a.m. UTC, <b>Alex \
Merry</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The new option needs documenting at the top of the \
file.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I'd like to have other Mac users / porters providing \
some input, if possible. In what circumstances would it be useful to use the new \
option? Is this going to affect homebrew or macports (ie: do they provide packages \
that they will have to set this option for, and is someone planning to inform them of \
this)?</p></pre> </blockquote>
<p>On September 12th, 2015, 9:05 p.m. UTC, <b>Samuel Gaist</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
idea I had behind that option was to let the users/porters decide whether or not they \
want to build against X11 on OS X. It might not make sense at first but since \
macports at least provides Xorg.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I didn't tought about \
informing them about it but I will gladly do it if the option stays.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Note that I'm not against removing it at all, it really is just to simplify \
life of people who would need to build against X11 on OS X.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's \
not the option I'm concerned about as such, it's the fact that this patch changes the \
default behaviour. So anyone wanting to build against X11 on OS X would now have to \
set this option, whereas before they just had to have Xorg installed and findable by \
CMake.</p></pre> <br />
<p>- Alex</p>
<br />
<p>On September 12th, 2015, 8:44 p.m. UTC, Samuel Gaist wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Extra Cmake Modules.</div>
<div>By Samuel Gaist.</div>
<p style="color: grey;"><i>Updated Sept. 12, 2015, 8:44 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Disable X11,XCB etc. detection on OS X</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">KCrash build on OS X 10.8</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kde-modules/KDECMakeSettings.cmake <span style="color: \
grey">(0c997931abee8673ccecc66d122108c6f72bf9b1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125163/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6782790068785568749==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic