[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-buildsystem
Subject: Re: Review Request 123841: Add arguments to ecm_add_tests for listing added tests.
From: "Stephen Kelly" <steveire () gmail ! com>
Date: 2015-05-18 19:19:41
Message-ID: 20150518191941.16315.49246 () mimi ! kde ! org
[Download RAW message or body]
--===============1825596089496812964==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123841/#review80601
-----------------------------------------------------------
Ship it!
Ship It!
modules/ECMAddTests.cmake (line 136)
<https://git.reviewboard.kde.org/r/123841/#comment55264>
This seems like it would be verbose and needless?
- Stephen Kelly
On May 18, 2015, 7:05 p.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123841/
> -----------------------------------------------------------
>
> (Updated May 18, 2015, 7:05 p.m.)
>
>
> Review request for Extra Cmake Modules.
>
>
> Bugs: 345797
> http://bugs.kde.org/show_bug.cgi?id=345797
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> Rework ECMAddTests documentation to emphasis ecm_add_tests().
>
> ecm_add_test is the less useful (and less used) version of the functions
> (because you really might as well just use add_executable() and
> add_test() manually in that case).
>
>
> Add arguments to ecm_add_tests for listing added tests.
>
> This makes it convenient to make further modifications to the tests,
> such as setting properties on either the tests or the targets.
>
> CHANGELOG: New arguments for ecm_add_tests().
> BUG: 345797
>
>
> Diffs
> -----
>
> modules/ECMAddTests.cmake bdb606919b49d5d8400a7d49935c0f569d279076
> tests/ECMAddTests/multi_tests/CMakeLists.txt \
> ca43477359fbfb8d41b1bb2ad08aeb3e75c99a1c tests/test_helpers.cmake \
> 73be343e5a9fe603e8c4ba042c833d3f9360b6df
> Diff: https://git.reviewboard.kde.org/r/123841/diff/
>
>
> Testing
> -------
>
> Added unit tests, which pass.
>
>
> Thanks,
>
> Alex Merry
>
>
--===============1825596089496812964==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123841/">https://git.reviewboard.kde.org/r/123841/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123841/diff/2/?file=370087#file370087line140" \
style="color: black; font-weight: bold; text-decoration: \
underline;">modules/ECMAddTests.cmake</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">136</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">message</span><span class="p">(</span><span class="s">STATUS</span> <span \
class="s2">"Target names: setting \
${ARG_TARGET_NAMES_VAR}=${_target_names}"</span><span \
class="p">)</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
seems like it would be verbose and needless?</p></pre> </div>
</div>
<br />
<p>- Stephen Kelly</p>
<br />
<p>On May 18th, 2015, 7:05 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Extra Cmake Modules.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated May 18, 2015, 7:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=345797">345797</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Rework ECMAddTests documentation to emphasis \
ecm_add_tests().</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">ecm_add_test is the less useful (and \
less used) version of the functions (because you really might as well just use \
add_executable() and add_test() manually in that case).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Add arguments to ecm_add_tests for listing added \
tests.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This makes it convenient to make further modifications \
to the tests, such as setting properties on either the tests or the targets.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">CHANGELOG: New arguments for \
ecm_add_tests().
BUG: 345797</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Added unit tests, which pass.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>modules/ECMAddTests.cmake <span style="color: \
grey">(bdb606919b49d5d8400a7d49935c0f569d279076)</span></li>
<li>tests/ECMAddTests/multi_tests/CMakeLists.txt <span style="color: \
grey">(ca43477359fbfb8d41b1bb2ad08aeb3e75c99a1c)</span></li>
<li>tests/test_helpers.cmake <span style="color: \
grey">(73be343e5a9fe603e8c4ba042c833d3f9360b6df)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123841/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1825596089496812964==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic