[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-buildsystem
Subject: Re: Review Request 122501: Do not call lrelease with -compress because it has some long-standing iss
From: Aurélien Gâteau <agateau () kde ! org>
Date: 2015-04-09 7:58:58
Message-ID: 20150409075858.31692.82388 () mimi ! kde ! org
[Download RAW message or body]
--===============3213687865849239740==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122501/#review78694
-----------------------------------------------------------
Ship it!
Ship It!
- Aurélien Gâteau
On avr. 9, 2015, 2:03 matin, Lasse Liehu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122501/
> -----------------------------------------------------------
>
> (Updated avr. 9, 2015, 2:03 matin)
>
>
> Review request for Build System and Aurélien Gâteau.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> Do not call lrelease with -compress
>
> According to Oswald Buddenhagen "it doesn't buy much, and there are some \
> long-standing issues with it".
> Qt bug report: https://bugreports.qt.io/browse/QTBUG-44362
>
>
> Diffs
> -----
>
> modules/ECMCreateQmFromPoFiles.cmake 3f134fb
> modules/ECMPoQmTools.cmake 015b7f9
>
> Diff: https://git.reviewboard.kde.org/r/122501/diff/
>
>
> Testing
> -------
>
> Manual testing. Generated qm files fine here.
>
>
> Thanks,
>
> Lasse Liehu
>
>
--===============3213687865849239740==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: \
1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122501/">https://git.reviewboard.kde.org/r/122501/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ship It!</pre> <br />
<p>- Aurélien Gâteau</p>
<br />
<p>On avril 9th, 2015, 2:03 matin CEST, Lasse Liehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" \
style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: \
6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Build System and Aurélien Gâteau.</div>
<div>By Lasse Liehu.</div>
<p style="color: grey;"><i>Updated avr. 9, 2015, 2:03 matin</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Do not call lrelease with \
-compress</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">According to Oswald \
Buddenhagen "it doesn't buy much, and there are some long-standing issues \
with it".</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Qt bug report: \
https://bugreports.qt.io/browse/QTBUG-44362</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Manual testing. Generated qm \
files fine here.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>modules/ECMCreateQmFromPoFiles.cmake <span style="color: \
grey">(3f134fb)</span></li>
<li>modules/ECMPoQmTools.cmake <span style="color: \
grey">(015b7f9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122501/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3213687865849239740==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic